| Message ID | 20180623151914.30931-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Enable AMD PCIe MP2 for AMDI0011 | expand |
It's a new driver and should have low impact to other devices.
Acked-By: AceLan Kao <acelan.kao@canonical.com>
On Sat, Jun 23, 2018 at 11:19:10PM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1773940 > > [Impact] > Touchpad doesn't work on Latitude 5495. > > [Test] > I can confirm the driver from AMD works. > With patch 2/3, no issues found so far. > > [Fix] > The touchpad connects to AMDI0011, which doesn't have any driver until > now. > > The original plan is to use an upstream version for this driver, but the > review process took longer than anticipated, and the driver is really in > need as the Latitude 5495 is about to hit the market. I'll replace this > patch set with upstream version once it's in mainline. > > [Regression Potential] > Low. It's a new driver, shouldn't affect any other device. New driver tied to specific hw ids, should not introduce regressions for supported hw. Acked-by: Seth Forshee <seth.forshee@canonical.com> Applied to cosmic/master-next and unstable/master, thanks!
On Mon, Jul 09, 2018 at 04:41:42PM -0500, Seth Forshee wrote: > On Sat, Jun 23, 2018 at 11:19:10PM +0800, Kai-Heng Feng wrote: > > BugLink: https://bugs.launchpad.net/bugs/1773940 > > > > [Impact] > > Touchpad doesn't work on Latitude 5495. > > > > [Test] > > I can confirm the driver from AMD works. > > With patch 2/3, no issues found so far. > > > > [Fix] > > The touchpad connects to AMDI0011, which doesn't have any driver until > > now. > > > > The original plan is to use an upstream version for this driver, but the > > review process took longer than anticipated, and the driver is really in > > need as the Latitude 5495 is about to hit the market. I'll replace this > > patch set with upstream version once it's in mainline. > > > > [Regression Potential] > > Low. It's a new driver, shouldn't affect any other device. > > New driver tied to specific hw ids, should not introduce regressions for > supported hw. > > Acked-by: Seth Forshee <seth.forshee@canonical.com> > > Applied to cosmic/master-next and unstable/master, thanks! This driver fails to build on architectures without ACPI support enabled. Probably the config option needs to depend on CONFIG_ACPI. Please test build all architectures before resending. Thanks, Seth
at 12:42, Seth Forshee <seth.forshee@canonical.com> wrote: > On Mon, Jul 09, 2018 at 04:41:42PM -0500, Seth Forshee wrote: >> On Sat, Jun 23, 2018 at 11:19:10PM +0800, Kai-Heng Feng wrote: >>> BugLink: https://bugs.launchpad.net/bugs/1773940 >>> >>> [Impact] >>> Touchpad doesn't work on Latitude 5495. >>> >>> [Test] >>> I can confirm the driver from AMD works. >>> With patch 2/3, no issues found so far. >>> >>> [Fix] >>> The touchpad connects to AMDI0011, which doesn't have any driver until >>> now. >>> >>> The original plan is to use an upstream version for this driver, but the >>> review process took longer than anticipated, and the driver is really in >>> need as the Latitude 5495 is about to hit the market. I'll replace this >>> patch set with upstream version once it's in mainline. >>> >>> [Regression Potential] >>> Low. It's a new driver, shouldn't affect any other device. >> >> New driver tied to specific hw ids, should not introduce regressions for >> supported hw. >> >> Acked-by: Seth Forshee <seth.forshee@canonical.com> >> >> Applied to cosmic/master-next and unstable/master, thanks! > > This driver fails to build on architectures without ACPI support > enabled. Probably the config option needs to depend on CONFIG_ACPI. > Please test build all architectures before resending. My apology. I didn't test architectures other than AMD64. Is there any way to build all architectures by debian/rules binary-generic? Kai-Heng > > Thanks, > Seth
On Thu, Jul 12, 2018 at 10:10:42AM +0800, Kai-Heng Feng wrote: > at 12:42, Seth Forshee <seth.forshee@canonical.com> wrote: > > > On Mon, Jul 09, 2018 at 04:41:42PM -0500, Seth Forshee wrote: > > > On Sat, Jun 23, 2018 at 11:19:10PM +0800, Kai-Heng Feng wrote: > > > > BugLink: https://bugs.launchpad.net/bugs/1773940 > > > > > > > > [Impact] > > > > Touchpad doesn't work on Latitude 5495. > > > > > > > > [Test] > > > > I can confirm the driver from AMD works. > > > > With patch 2/3, no issues found so far. > > > > > > > > [Fix] > > > > The touchpad connects to AMDI0011, which doesn't have any driver until > > > > now. > > > > > > > > The original plan is to use an upstream version for this driver, but the > > > > review process took longer than anticipated, and the driver is really in > > > > need as the Latitude 5495 is about to hit the market. I'll replace this > > > > patch set with upstream version once it's in mainline. > > > > > > > > [Regression Potential] > > > > Low. It's a new driver, shouldn't affect any other device. > > > > > > New driver tied to specific hw ids, should not introduce regressions for > > > supported hw. > > > > > > Acked-by: Seth Forshee <seth.forshee@canonical.com> > > > > > > Applied to cosmic/master-next and unstable/master, thanks! > > > > This driver fails to build on architectures without ACPI support > > enabled. Probably the config option needs to depend on CONFIG_ACPI. > > Please test build all architectures before resending. > > My apology. I didn't test architectures other than AMD64. > > Is there any way to build all architectures by debian/rules binary-generic? Yes, we usually use chroots for that. Seth
BugLink: https://bugs.launchpad.net/bugs/1773940 [Impact] Touchpad doesn't work on Latitude 5495. [Test] I can confirm the driver from AMD works. With patch 2/3, no issues found so far. [Fix] The touchpad connects to AMDI0011, which doesn't have any driver until now. The original plan is to use an upstream version for this driver, but the review process took longer than anticipated, and the driver is really in need as the Latitude 5495 is about to hit the market. I'll replace this patch set with upstream version once it's in mainline. [Regression Potential] Low. It's a new driver, shouldn't affect any other device. Kai-Heng Feng (2): UBUNTU: SAUCE: i2c:amd move out pointer in union i2c_event_base UBUNTU: [Config] i2c: CONFIG_I2C_AMD_MP2=y Nehal-bakulchandra Shah (1): UBUNTU: SAUCE: i2c:amd I2C Driver based on PCI Interface for upcoming platform debian.master/config/config.common.ubuntu | 1 + drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 2 + drivers/i2c/busses/i2c-amd-pci-mp2.c | 625 ++++++++++++++++++++++ drivers/i2c/busses/i2c-amd-pci-mp2.h | 253 +++++++++ drivers/i2c/busses/i2c-amd-platdrv.c | 335 ++++++++++++ 6 files changed, 1226 insertions(+) create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.c create mode 100644 drivers/i2c/busses/i2c-amd-pci-mp2.h create mode 100644 drivers/i2c/busses/i2c-amd-platdrv.c