| Message ID | 1529095472-15625-1-git-send-email-kamal@canonical.com |
|---|---|
| Headers | show |
| Series | debian.py: fix changelog[content, bugs] off-by-one | expand |
On 15.06.2018 22:44, Kamal Mostafa wrote: > PATCH 1/2: debian.py: fix changelog[content,bugs] off-by-one > > The debian changelog parser in debian.py (both implementations) is bugged > such that the ['content'] and ['bugs'] values for each changelog[N] actually > get placed in changelog[N+1]. I.e. changelog[0] represents the topmost > changelog entry but its changelog[0]['content'] and changelog[0]['bugs'] > are always empty; their values end up in changelog[1]. > > Fix the buggy debian.py changelog parser behavior and verify-release-ready's > expectation of it. > > IMPORTANT: Any other out-of-tree users of this debian.py changelog > parser will see a behavior change w.r.t. the ['content'] and ['bugs'] > elements. > > > PATCH 2/2: verify-release-ready: rename internal cl variables > > No functional change; rename internal variables for sanity. > > > -Kamal > > ---- > > Kamal Mostafa (2): > debian.py: fix changelog[content,bugs] off-by-one > verify-release-ready: rename internal cl variables > > ktl/debian.py | 41 +++++++------ > maintscripts/verify-release-ready | 118 +++++++++++++++++++------------------- > py3/lib/debian.py | 33 ++++++----- > 3 files changed, 102 insertions(+), 90 deletions(-) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
I have looked for possible issues with some of the use and changes I have made recently with the python3 version and the change seems fine there. I also looked at one specific use on verify-release-ready, the series/package issue that you mentioned, and as it's looking for bugs there, it seems fine too. Thanks. Cascardo.
On Fri, Jun 15, 2018 at 01:44:30PM -0700, Kamal Mostafa wrote: > PATCH 1/2: debian.py: fix changelog[content,bugs] off-by-one > > The debian changelog parser in debian.py (both implementations) is bugged > such that the ['content'] and ['bugs'] values for each changelog[N] actually > get placed in changelog[N+1]. I.e. changelog[0] represents the topmost > changelog entry but its changelog[0]['content'] and changelog[0]['bugs'] > are always empty; their values end up in changelog[1]. > > Fix the buggy debian.py changelog parser behavior and verify-release-ready's > expectation of it. > > IMPORTANT: Any other out-of-tree users of this debian.py changelog > parser will see a behavior change w.r.t. the ['content'] and ['bugs'] > elements. > > > PATCH 2/2: verify-release-ready: rename internal cl variables > > No functional change; rename internal variables for sanity. > > > -Kamal > > ---- > > Kamal Mostafa (2): > debian.py: fix changelog[content,bugs] off-by-one > verify-release-ready: rename internal cl variables > > ktl/debian.py | 41 +++++++------ > maintscripts/verify-release-ready | 118 +++++++++++++++++++------------------- > py3/lib/debian.py | 33 ++++++----- > 3 files changed, 102 insertions(+), 90 deletions(-) > > -- > 2.7.4 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team