diff mbox series

binman: Fix SyntaxWarning: invalid escape sequence '\('

Message ID tencent_0D22B14196104C56C3E5BB4AD46BCF283306@qq.com
State Superseded
Delegated to: Simon Glass
Headers show
Series binman: Fix SyntaxWarning: invalid escape sequence '\(' | expand

Commit Message

Rong Tao Sept. 4, 2023, 11 a.m. UTC 
From: Rong Tao <rongtao@cestc.cn>

Reproduct warning:

    $ sudo git clean -dfx
    $ make CROSS_COMPILE="" qemu-x86_64_defconfig
    $ sudo make -j8
    ...
    u-boot/tools/binman/etype/section.py:25:
    SyntaxWarning: invalid escape sequence '\('
    """Entry that contains other entries

Signed-off-by: Rong Tao <rongtao@cestc.cn>
---
 tools/binman/etype/section.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Sept. 4, 2023, 4:48 p.m. UTC | #1 
Hi Rong,

On Mon, 4 Sept 2023 at 05:00, Rong Tao <rtoax@foxmail.com> wrote:
>
> From: Rong Tao <rongtao@cestc.cn>
>
> Reproduct warning:
>
>     $ sudo git clean -dfx
>     $ make CROSS_COMPILE="" qemu-x86_64_defconfig
>     $ sudo make -j8

I hope you don't need sudo

>     ...
>     u-boot/tools/binman/etype/section.py:25:
>     SyntaxWarning: invalid escape sequence '\('
>     """Entry that contains other entries
>
> Signed-off-by: Rong Tao <rongtao@cestc.cn>
> ---
>  tools/binman/etype/section.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
> index fb49e85a7634..30c1041c7e8d 100644
> --- a/tools/binman/etype/section.py
> +++ b/tools/binman/etype/section.py
> @@ -40,7 +40,7 @@ class Entry_section(Entry):
>      For example code, see etypes which subclass `Entry_section`, or `cbfs.py`
>      for a more involved example::
>
> -       $ grep -l \(Entry_section tools/binman/etype/*.py
> +       $ grep -l \\(Entry_section tools/binman/etype/*.py
>
>      ReadNode()
>          Call `super().ReadNode()`, then read any special properties for the
> --
> 2.41.0
>

Can you please regenerate entries.rst as well? We need to keep that in sync.

Regards,
Simon
Rong Tao Sept. 5, 2023, 11:42 a.m. UTC | #2 
I Just try


&nbsp; &nbsp; binman entry-docs &gt; entries.rst
&nbsp; &nbsp; git difff


It didn't change anything.


Rong Tao
diff mbox series

Patch

diff --git a/tools/binman/etype/section.py b/tools/binman/etype/section.py
index fb49e85a7634..30c1041c7e8d 100644
--- a/tools/binman/etype/section.py
+++ b/tools/binman/etype/section.py
@@ -40,7 +40,7 @@  class Entry_section(Entry):
     For example code, see etypes which subclass `Entry_section`, or `cbfs.py`
     for a more involved example::
 
-       $ grep -l \(Entry_section tools/binman/etype/*.py
+       $ grep -l \\(Entry_section tools/binman/etype/*.py
 
     ReadNode()
         Call `super().ReadNode()`, then read any special properties for the