| Message ID | fc5f5e2aeca77847ed4ca6a263890375ab9f5163.1642162545.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | a2d5f3d133b4ce4e7cb0fcf1d761c75c4f1b2f8d |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | Revert "net: gem: Disable broadcast setting" | expand |
On Fri, Jan 14, 2022 at 2:15 PM Michal Simek <michal.simek@xilinx.com> wrote: > > This reverts commit eafdcda4a854932c0319656de7bf3f017f17ae67. > > The main reason is that QEMU is using BOOTP protocol which is sending DHCP > Offer to a broadcast address that's why it can't be disabled. > DHCP protocol has no issue because it returns directly to client MAC > address. > Both of these options are described in RFC951 > (https://datatracker.ietf.org/doc/html/rfc951#section-4) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/zynq_gem.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c > index f238811786c6..3118d1472669 100644 > --- a/drivers/net/zynq_gem.c > +++ b/drivers/net/zynq_gem.c > @@ -62,7 +62,6 @@ > #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */ > #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */ > #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */ > -#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */ > #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */ > #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */ > #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */ > @@ -80,7 +79,6 @@ > > #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \ > ZYNQ_GEM_NWCFG_FDEN | \ > - ZYNQ_GEM_NWCFG_NO_BRDC | \ > ZYNQ_GEM_NWCFG_FSREM | \ > ZYNQ_GEM_NWCFG_MDCCLKDIV) > > -- > 2.34.1 > Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
pá 14. 1. 2022 v 13:15 odesílatel Michal Simek <michal.simek@xilinx.com> napsal: > > This reverts commit eafdcda4a854932c0319656de7bf3f017f17ae67. > > The main reason is that QEMU is using BOOTP protocol which is sending DHCP > Offer to a broadcast address that's why it can't be disabled. > DHCP protocol has no issue because it returns directly to client MAC > address. > Both of these options are described in RFC951 > (https://datatracker.ietf.org/doc/html/rfc951#section-4) > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/net/zynq_gem.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c > index f238811786c6..3118d1472669 100644 > --- a/drivers/net/zynq_gem.c > +++ b/drivers/net/zynq_gem.c > @@ -62,7 +62,6 @@ > #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */ > #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */ > #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */ > -#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */ > #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */ > #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */ > #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */ > @@ -80,7 +79,6 @@ > > #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \ > ZYNQ_GEM_NWCFG_FDEN | \ > - ZYNQ_GEM_NWCFG_NO_BRDC | \ > ZYNQ_GEM_NWCFG_FSREM | \ > ZYNQ_GEM_NWCFG_MDCCLKDIV) > > -- > 2.34.1 > applied. M
diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c index f238811786c6..3118d1472669 100644 --- a/drivers/net/zynq_gem.c +++ b/drivers/net/zynq_gem.c @@ -62,7 +62,6 @@ #define ZYNQ_GEM_NWCFG_SPEED100 0x00000001 /* 100 Mbps operation */ #define ZYNQ_GEM_NWCFG_SPEED1000 0x00000400 /* 1Gbps operation */ #define ZYNQ_GEM_NWCFG_FDEN 0x00000002 /* Full Duplex mode */ -#define ZYNQ_GEM_NWCFG_NO_BRDC BIT(5) /* No broadcast */ #define ZYNQ_GEM_NWCFG_FSREM 0x00020000 /* FCS removal */ #define ZYNQ_GEM_NWCFG_SGMII_ENBL 0x08000000 /* SGMII Enable */ #define ZYNQ_GEM_NWCFG_PCS_SEL 0x00000800 /* PCS select */ @@ -80,7 +79,6 @@ #define ZYNQ_GEM_NWCFG_INIT (ZYNQ_GEM_DBUS_WIDTH | \ ZYNQ_GEM_NWCFG_FDEN | \ - ZYNQ_GEM_NWCFG_NO_BRDC | \ ZYNQ_GEM_NWCFG_FSREM | \ ZYNQ_GEM_NWCFG_MDCCLKDIV)
This reverts commit eafdcda4a854932c0319656de7bf3f017f17ae67. The main reason is that QEMU is using BOOTP protocol which is sending DHCP Offer to a broadcast address that's why it can't be disabled. DHCP protocol has no issue because it returns directly to client MAC address. Both of these options are described in RFC951 (https://datatracker.ietf.org/doc/html/rfc951#section-4) Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/net/zynq_gem.c | 2 -- 1 file changed, 2 deletions(-)