| Message ID | efa717258c88c8f37baa1d3afcc618859be5f9b3.1480538807.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Delegated to: | Michal Simek |
| Headers | show |
On Wed, Nov 30, 2016 at 09:46:49PM +0100, Michal Simek wrote: > Two functions should be static because they are not exported to any > other file. > Warnings were reported by sparse C=1. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On 30 November 2016 at 13:46, Michal Simek <michal.simek@xilinx.com> wrote: > Two functions should be static because they are not exported to any > other file. > Warnings were reported by sparse C=1. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > cmd/scsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/cmd/scsi.c b/cmd/scsi.c index 387ca1a262ab..a9c954a82f3d 100644 --- a/cmd/scsi.c +++ b/cmd/scsi.c @@ -17,7 +17,7 @@ static int scsi_curr_dev; /* current device */ /* * scsi boot command intepreter. Derived from diskboot */ -int do_scsiboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) +static int do_scsiboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) { return common_diskboot(cmdtp, "scsi", argc, argv); } @@ -25,7 +25,7 @@ int do_scsiboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) /* * scsi command intepreter */ -int do_scsi(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) +static int do_scsi(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) { switch (argc) { case 0:
Two functions should be static because they are not exported to any other file. Warnings were reported by sparse C=1. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- cmd/scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)