diff mbox series

[v2,3/5] Kconfig: Add missing quotes around default string value

Message ID e7206c2695459ad0c1a1f0040d9bd286c2fa109a.1713250508.git.michal.simek@amd.com
State Accepted
Commit 99ac431c09b9e00c9b44c4b1d9a7c19efff90f0f
Delegated to: Tom Rini
Headers show
Series Kconfig: some cleanups | expand

Commit Message

Michal Simek April 16, 2024, 6:55 a.m. UTC
All errors are generated by ./tools/qconfig.py -b -j8 -i whatever.
Error look like this:
warning: style: quotes recommended around default value for string symbol
EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)

Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

(no changes since v1)

 lib/efi_loader/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ilias Apalodimas April 16, 2024, 7:48 a.m. UTC | #1
On Tue, 16 Apr 2024 at 09:55, Michal Simek <michal.simek@amd.com> wrote:
>
> All errors are generated by ./tools/qconfig.py -b -j8 -i whatever.
> Error look like this:
> warning: style: quotes recommended around default value for string symbol
> EFI_VAR_SEED_FILE (defined at lib/efi_loader/Kconfig:130)
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>
> (no changes since v1)
>
>  lib/efi_loader/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index e13a6f9f4c3a..a5ab7d1b262f 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -129,7 +129,7 @@ if EFI_VARIABLES_PRESEED
>
>  config EFI_VAR_SEED_FILE
>         string "File with initial values of non-volatile UEFI variables"
> -       default ubootefi.var
> +       default "ubootefi.var"
>         help
>           File with initial values of non-volatile UEFI variables. The file must
>           be in the same format as the storage in the EFI system partition. The
> --
> 2.44.0
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index e13a6f9f4c3a..a5ab7d1b262f 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -129,7 +129,7 @@  if EFI_VARIABLES_PRESEED
 
 config EFI_VAR_SEED_FILE
 	string "File with initial values of non-volatile UEFI variables"
-	default ubootefi.var
+	default "ubootefi.var"
 	help
 	  File with initial values of non-volatile UEFI variables. The file must
 	  be in the same format as the storage in the EFI system partition. The