| Message ID | d7368b5886e8899e62bbd1ceab52df7181bb196f.1629371983.git.michal.simek@xilinx.com |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | xilinx: Add support for DTB reselection | expand |
On 8/19/21 12:19 PM, Michal Simek wrote: Hi Michal, > DTBs for 64bit systems should be also 64bit aligned. What does "align" mean here, exactly? This is about generating .dtb *files*, right? dtc makes sure that the internal structures are properly aligned, so what else should be aligned here? > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > arch/arm/dts/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index 537c96bf5b35..8d4fc333ea7a 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -1,5 +1,9 @@ > # SPDX-License-Identifier: GPL-2.0+ > > +ifdef CONFIG_PHYS_64BIT > +DTC_FLAGS += -a 0x8 By looking into the dtc source this looks like to make sure the *size* of the DTB is 8-byte aligned, is that the intention here, or even useful? If it is, it should apply unconditionally, not only to 64-bit systems. Cheers, Andre > +endif > + > dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb > dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb > dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb >
Hi Andre, On 8/19/21 6:10 PM, Andre Przywara wrote: > On 8/19/21 12:19 PM, Michal Simek wrote: > > Hi Michal, > >> DTBs for 64bit systems should be also 64bit aligned. > > What does "align" mean here, exactly? This is about generating .dtb > *files*, right? dtc makes sure that the internal structures are properly > aligned, so what else should be aligned here? > >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> arch/arm/dts/Makefile | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile >> index 537c96bf5b35..8d4fc333ea7a 100644 >> --- a/arch/arm/dts/Makefile >> +++ b/arch/arm/dts/Makefile >> @@ -1,5 +1,9 @@ >> # SPDX-License-Identifier: GPL-2.0+ >> +ifdef CONFIG_PHYS_64BIT >> +DTC_FLAGS += -a 0x8 > > By looking into the dtc source this looks like to make sure the *size* > of the DTB is 8-byte aligned, is that the intention here, or even > useful? If it is, it should apply unconditionally, not only to 64-bit > systems. The question is correct. I did it mostly for being safe that DTBs start and end is 64bit aligned. I didn't hit any issue with not aligned end and maybe it is not useful to do it. It was just more convenient for me to work with also 64bit aligned image size. Thanks, Michal
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index 537c96bf5b35..8d4fc333ea7a 100644 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -1,5 +1,9 @@ # SPDX-License-Identifier: GPL-2.0+ +ifdef CONFIG_PHYS_64BIT +DTC_FLAGS += -a 0x8 +endif + dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
DTBs for 64bit systems should be also 64bit aligned. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- arch/arm/dts/Makefile | 4 ++++ 1 file changed, 4 insertions(+)