| Message ID | c1a9e6b6347fe9e2c36858f082f3ca452b328fd2.1498132599.git.christophe.leroy@c-s.fr |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Jun 23, 2017 at 02:57:38PM +0200, Christophe Leroy wrote: > LXT973 PHY is a PHY of the LXT970 family. This patch > ensures the fec driver supports it. > > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> Reviewed-by: Tom Rini <trini@konsulko.com> And, please make a note on your TODO list that the driver needs to be updated to use phylib, thanks!
Dear Christophe, [adding Joe on Cc:] In message <c1a9e6b6347fe9e2c36858f082f3ca452b328fd2.1498132599.git.christophe.leroy@c-s.fr> you wrote: > LXT973 PHY is a PHY of the LXT970 family. This patch > ensures the fec driver supports it. This patch is totally unrelated to 8xx; it should go through the network maintainer [adding Joe on Cc:] > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > --- > arch/powerpc/cpu/mpc8xx/fec.c | 4 ++++ > 1 file changed, 4 insertions(+) Otherwise: Reviewed-by: Wolfgang Denk <wd@denx.de> Best regards, Wolfgang Denk
Hi, On Fri, Jun 23, 2017 at 8:45 AM, Wolfgang Denk <wd@denx.de> wrote: > Dear Christophe, > > [adding Joe on Cc:] > > In message <c1a9e6b6347fe9e2c36858f082f3ca452b328fd2.1498132599.git.christophe.leroy@c-s.fr> you wrote: >> LXT973 PHY is a PHY of the LXT970 family. This patch >> ensures the fec driver supports it. > > This patch is totally unrelated to 8xx; it should go through the > network maintainer [adding Joe on Cc:] >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> >> --- >> arch/powerpc/cpu/mpc8xx/fec.c | 4 ++++ This file does not exist. All support for 8xx has been removed. >> 1 file changed, 4 insertions(+) > > Otherwise: > > Reviewed-by: Wolfgang Denk <wd@denx.de> > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de > Artificial Intelligence is the study of how to make real computers > act like the ones in movies. > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
diff --git a/arch/powerpc/cpu/mpc8xx/fec.c b/arch/powerpc/cpu/mpc8xx/fec.c index b27310fffb..680d286964 100644 --- a/arch/powerpc/cpu/mpc8xx/fec.c +++ b/arch/powerpc/cpu/mpc8xx/fec.c @@ -738,6 +738,7 @@ static void fec_halt(struct eth_device* dev) */ #define PHY_ID_LXT970 0x78100000 /* LXT970 */ #define PHY_ID_LXT971 0x001378e0 /* LXT971 and 972 */ +#define PHY_ID_LXT973 0x00137A10 /* LXT973 */ #define PHY_ID_82555 0x02a80150 /* Intel 82555 */ #define PHY_ID_QS6612 0x01814400 /* QS6612 */ #define PHY_ID_AMD79C784 0x00225610 /* AMD 79C784 */ @@ -814,6 +815,9 @@ static int mii_discover_phy(struct eth_device *dev) case PHY_ID_LXT971: printf("LXT971\n"); break; + case PHY_ID_LXT973: + printf("LXT973\n"); + break; case PHY_ID_82555: printf("82555\n"); break;
LXT973 PHY is a PHY of the LXT970 family. This patch ensures the fec driver supports it. Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> --- arch/powerpc/cpu/mpc8xx/fec.c | 4 ++++ 1 file changed, 4 insertions(+)