| Message ID | acf50fb6f3ea0466580b731311a28a7de29b2b63.1387390491.git.p.marczak@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
On 19/12/13 03:31, Przemyslaw Marczak wrote: > This change avoids unexpected unaligned access. > > more info: README.arm-unaligned-accesses > > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> > cc: Lukasz Majewski <l.majewski@samsung.com> > > --- > Changes v2: > - new patch > --- > board/samsung/trats/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/board/samsung/trats/Makefile b/board/samsung/trats/Makefile > index 5dc8a1f..c1bcd63 100644 > --- a/board/samsung/trats/Makefile > +++ b/board/samsung/trats/Makefile > @@ -6,3 +6,5 @@ > # > > obj-y += trats.o > + > +$(obj)trats.o: CFLAGS += $(PLATFORM_NO_UNALIGNED) > \ No newline at end of file > What is the example of unexpected unaligned access on trats? Thanks, Minkyu Kang.
Hello Minkyu, On 01/02/2014 07:35 AM, Minkyu Kang wrote: > On 19/12/13 03:31, Przemyslaw Marczak wrote: >> This change avoids unexpected unaligned access. >> >> more info: README.arm-unaligned-accesses >> >> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> >> cc: Lukasz Majewski <l.majewski@samsung.com> >> >> --- >> Changes v2: >> - new patch >> --- >> board/samsung/trats/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/board/samsung/trats/Makefile b/board/samsung/trats/Makefile >> index 5dc8a1f..c1bcd63 100644 >> --- a/board/samsung/trats/Makefile >> +++ b/board/samsung/trats/Makefile >> @@ -6,3 +6,5 @@ >> # >> >> obj-y += trats.o >> + >> +$(obj)trats.o: CFLAGS += $(PLATFORM_NO_UNALIGNED) >> \ No newline at end of file >> > > What is the example of unexpected unaligned access on trats? > > Thanks, > Minkyu Kang. > There was unaligned access exception on Trats before booting the linux and I checked that this flag resolved this issue. After adding some v3 changes I can see that this is not a solution for this issue. I am working on it and this commit will be removed in patch set V3. Regards
diff --git a/board/samsung/trats/Makefile b/board/samsung/trats/Makefile index 5dc8a1f..c1bcd63 100644 --- a/board/samsung/trats/Makefile +++ b/board/samsung/trats/Makefile @@ -6,3 +6,5 @@ # obj-y += trats.o + +$(obj)trats.o: CFLAGS += $(PLATFORM_NO_UNALIGNED)
This change avoids unexpected unaligned access. more info: README.arm-unaligned-accesses Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> cc: Lukasz Majewski <l.majewski@samsung.com> --- Changes v2: - new patch --- board/samsung/trats/Makefile | 2 ++ 1 file changed, 2 insertions(+) \ No newline at end of file