| Message ID | YO3/WmyXZfbj+jbf@mini.fritz.box |
|---|---|
| State | Accepted |
| Commit | 0523326af4e505d837968a5694c99c0ee1d0041c |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | mux: correct prototype for mux_control_try_select() | expand |
-JJ since the email would bounce. On 13/07/21 11:02PM, Patrick Wildt wrote: > The macro should be passed a state, which should be passed > to the actual function. Otherwise using that macro would > yield a build error. Nitpick: Lines are too short. The usual convention is 72 chars and you seem to be terminating them at 60. Other than this, Reviewed-by: Pratyush Yadav <p.yadav@ti.com> > > Signed-off-by: Patrick Wildt <patrick@blueri.se> > --- > include/mux.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/mux.h b/include/mux.h > index 23844f480a..9f80991274 100644 > --- a/include/mux.h > +++ b/include/mux.h > @@ -51,7 +51,7 @@ unsigned int mux_control_states(struct mux_control *mux); > */ > int __must_check mux_control_select(struct mux_control *mux, > unsigned int state); > -#define mux_control_try_select(mux) mux_control_select(mux) > +#define mux_control_try_select(mux, state) mux_control_select(mux, state) > > /** > * mux_control_deselect() - Deselect the previously selected multiplexer state. > @@ -128,7 +128,7 @@ int __must_check mux_control_select(struct mux_control *mux, > return -ENOSYS; > } > > -#define mux_control_try_select(mux) mux_control_select(mux) > +#define mux_control_try_select(mux, state) mux_control_select(mux, state) > > int mux_control_deselect(struct mux_control *mux) > { > -- > 2.32.0 >
On Tue, Jul 13, 2021 at 11:02:18PM +0200, Patrick Wildt wrote: > The macro should be passed a state, which should be passed > to the actual function. Otherwise using that macro would > yield a build error. > > Signed-off-by: Patrick Wildt <patrick@blueri.se> > Reviewed-by: Pratyush Yadav <p.yadav@ti.com> Applied to u-boot/master, thanks!
diff --git a/include/mux.h b/include/mux.h index 23844f480a..9f80991274 100644 --- a/include/mux.h +++ b/include/mux.h @@ -51,7 +51,7 @@ unsigned int mux_control_states(struct mux_control *mux); */ int __must_check mux_control_select(struct mux_control *mux, unsigned int state); -#define mux_control_try_select(mux) mux_control_select(mux) +#define mux_control_try_select(mux, state) mux_control_select(mux, state) /** * mux_control_deselect() - Deselect the previously selected multiplexer state. @@ -128,7 +128,7 @@ int __must_check mux_control_select(struct mux_control *mux, return -ENOSYS; } -#define mux_control_try_select(mux) mux_control_select(mux) +#define mux_control_try_select(mux, state) mux_control_select(mux, state) int mux_control_deselect(struct mux_control *mux) {
The macro should be passed a state, which should be passed to the actual function. Otherwise using that macro would yield a build error. Signed-off-by: Patrick Wildt <patrick@blueri.se> --- include/mux.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)