| Message ID | CAPnjgZ2t_fDEFfP=1KdJt+0t3kSxmpQNQ=9hBU84wFFefGt06g@mail.gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
2014-09-23 0:33 GMT+09:00 Simon Glass <sjg@chromium.org>: > ---------------------------------------------------------------- > Jagannadha Sutradharudu Teki (1): > sandbox: Update minor documentation changes As I commented in http://patchwork.ozlabs.org/patch/384547/ the second hunk does not make sense at all and not fixed yet.
Hi Masahiro, On 22 September 2014 11:13, Masahiro YAMADA <yamada.m@jp.panasonic.com> wrote: > 2014-09-23 0:33 GMT+09:00 Simon Glass <sjg@chromium.org>: > >> ---------------------------------------------------------------- >> Jagannadha Sutradharudu Teki (1): >> sandbox: Update minor documentation changes > > > As I commented in > http://patchwork.ozlabs.org/patch/384547/ > the second hunk does not make sense at all > and not fixed yet. I did read your comment but thought it was addressed. Are you wanting to change this line also? > The chosen vendor and board names are also 'sandbox', so there is a single Let me know what you'd like it to say, and I'll prepare a patch. Regards, Simon
2014-09-23 2:26 GMT+09:00 Simon Glass <sjg@chromium.org>: > Hi Masahiro, > > On 22 September 2014 11:13, Masahiro YAMADA <yamada.m@jp.panasonic.com> wrote: >> 2014-09-23 0:33 GMT+09:00 Simon Glass <sjg@chromium.org>: >> >>> ---------------------------------------------------------------- >>> Jagannadha Sutradharudu Teki (1): >>> sandbox: Update minor documentation changes >> >> >> As I commented in >> http://patchwork.ozlabs.org/patch/384547/ >> the second hunk does not make sense at all >> and not fixed yet. > > I did read your comment but thought it was addressed. Are you wanting > to change this line also? > >> The chosen vendor and board names are also 'sandbox', so there is a single > > Let me know what you'd like it to say, and I'll prepare a patch. Prior to commit 2dabac1337facbd (sandbox: set sandbox's vendor to null), the following statement was correct: The chosen vendor and board names are also 'sandbox', so there is a single board in board/sandbox/sandbox. Since commit 2dabac1337facbd: The board name is 'sandbox' but the vendor name is unset, so there is a single board in board/sandbox. (Note, the board directory is specified by board/${VENDOR}/${BOARD}, or board/${BOARD} if VENDOR is null. )
On Tue, Sep 23, 2014 at 12:10:41PM +0900, Masahiro YAMADA wrote: > 2014-09-23 2:26 GMT+09:00 Simon Glass <sjg@chromium.org>: > > Hi Masahiro, > > > > On 22 September 2014 11:13, Masahiro YAMADA <yamada.m@jp.panasonic.com> wrote: > >> 2014-09-23 0:33 GMT+09:00 Simon Glass <sjg@chromium.org>: > >> > >>> ---------------------------------------------------------------- > >>> Jagannadha Sutradharudu Teki (1): > >>> sandbox: Update minor documentation changes > >> > >> > >> As I commented in > >> http://patchwork.ozlabs.org/patch/384547/ > >> the second hunk does not make sense at all > >> and not fixed yet. > > > > I did read your comment but thought it was addressed. Are you wanting > > to change this line also? > > > >> The chosen vendor and board names are also 'sandbox', so there is a single > > > > Let me know what you'd like it to say, and I'll prepare a patch. > > > Prior to commit 2dabac1337facbd (sandbox: set sandbox's vendor to null), > the following statement was correct: > The chosen vendor and board names are also 'sandbox', so there is a single > board in board/sandbox/sandbox. > > > Since commit 2dabac1337facbd: > The board name is 'sandbox' but the vendor name is unset, so there is a single > board in board/sandbox. > > > > (Note, the board directory is specified by board/${VENDOR}/${BOARD}, > or board/${BOARD} if VENDOR is null. ) Since we're talking docs and you guys are sorting it out now, I'll grab the current PR and then deal with another minor update after.
On Mon, Sep 22, 2014 at 09:33:37AM -0600, Simon Glass wrote: > Hi Tom, > > Here are some minor fixes for sandbox, buildman and patman. > > > The following changes since commit 9170818a4e004af7893fa0113f6e5b4afafded55: > > kconfiglib: change SPDX-License-Identifier to ISC (2014-09-17 21:03:18 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-x86.git misc > > for you to fetch changes up to 983a2749e2fdc459b2f44e82241a5c314ddbcdf6: > > patman: Add a -m option to avoid copying the maintainers (2014-09-21 > 12:03:07 -0600) > > ---------------------------------------------------------------- > Jagannadha Sutradharudu Teki (1): > sandbox: Update minor documentation changes > > Simon Glass (2): > buildman: Fix the logic for the bloat command > patman: Add a -m option to avoid copying the maintainers > > README | 2 +- > board/sandbox/README.sandbox | 6 +++--- > tools/buildman/control.py | 6 +++--- > tools/patman/README | 4 ++-- > tools/patman/patman.py | 6 +++++- > tools/patman/series.py | 7 +++++-- > 6 files changed, 19 insertions(+), 12 deletions(-) Applied to u-boot/master, thanks!
Hi Tom, Here are some minor fixes for sandbox, buildman and patman. The following changes since commit 9170818a4e004af7893fa0113f6e5b4afafded55: kconfiglib: change SPDX-License-Identifier to ISC (2014-09-17 21:03:18 -0400) are available in the git repository at: git://git.denx.de/u-boot-x86.git misc for you to fetch changes up to 983a2749e2fdc459b2f44e82241a5c314ddbcdf6: patman: Add a -m option to avoid copying the maintainers (2014-09-21 12:03:07 -0600) ---------------------------------------------------------------- Jagannadha Sutradharudu Teki (1): sandbox: Update minor documentation changes Simon Glass (2): buildman: Fix the logic for the bloat command patman: Add a -m option to avoid copying the maintainers README | 2 +- board/sandbox/README.sandbox | 6 +++--- tools/buildman/control.py | 6 +++--- tools/patman/README | 4 ++-- tools/patman/patman.py | 6 +++++- tools/patman/series.py | 7 +++++-- 6 files changed, 19 insertions(+), 12 deletions(-) Regards, Simon