Message ID | CAPnjgZ1UEGAGW-aibBWSTAMg+p0pDoWqxenHyApDSYFnuYuiLw@mail.gmail.com |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot] Please pull u-boot-dm | expand |
Hi Tom, On 9 October 2018 at 18:24, Simon Glass <sjg@chromium.org> wrote: > > Hi Tom, > > Here is my attempt at a signed pull request. I've brought in most of the outstanding dm patches. Please let me know if it looks OK. Do you have my public key? > Build result here: https://travis-ci.org/sglass68/u-boot/builds/439071186 Regards, Simon
On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > Hi Tom, > > Here is my attempt at a signed pull request. I've brought in most of the > outstanding dm patches. Please let me know if it looks OK. Do you have my > public key? Is it on the public key servers? > > > The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: > > Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 > -0400) > > are available in the Git repository at: > > git://git.denx.de/u-boot-dm.git tags/dm-9oct18 > > for you to fetch changes up to 41b781ddf1869f5349e05ace888979f3673fe8c6: > > dtoc: Fix the value of SetInt() (2018-10-09 04:40:27 -0600) > Applied to u-boot/master, thanks!
Hi Tom, On 11 October 2018 at 07:10, Tom Rini <trini@konsulko.com> wrote: > On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > >> Hi Tom, >> >> Here is my attempt at a signed pull request. I've brought in most of the >> outstanding dm patches. Please let me know if it looks OK. Do you have my >> public key? > > Is it on the public key servers? Yes, here: https://pgp.mit.edu/pks/lookup?search=sjg%40chromium&op=index > >> >> >> The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: >> >> Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 >> -0400) >> >> are available in the Git repository at: >> >> git://git.denx.de/u-boot-dm.git tags/dm-9oct18 >> >> for you to fetch changes up to 41b781ddf1869f5349e05ace888979f3673fe8c6: >> >> dtoc: Fix the value of SetInt() (2018-10-09 04:40:27 -0600) >> > > Applied to u-boot/master, thanks! > > -- > Tom
On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: > Hi Tom, > > On 11 October 2018 at 07:10, Tom Rini <trini@konsulko.com> wrote: > > On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > > > >> Hi Tom, > >> > >> Here is my attempt at a signed pull request. I've brought in most of the > >> outstanding dm patches. Please let me know if it looks OK. Do you have my > >> public key? > > > > Is it on the public key servers? > > Yes, here: > > https://pgp.mit.edu/pks/lookup?search=sjg%40chromium&op=index So yes, it is working. On your latest PR: $ git show --show-signature commit 1d6edcbfed2af33c748f2beb399810a0441888da merged tag 'pull-14nov18' gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID 9008ADE6 gpg: Good signature from "Simon Glass <sjg@chromium.org>" Merge: f6206f8587fc 4c6e27f63c88 Author: Tom Rini <trini@konsulko.com> Date: Fri Nov 16 08:37:50 2018 -0500 Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm Thanks again!
Hi Tom, On 16 November 2018 at 05:45, Tom Rini <trini@konsulko.com> wrote: > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: >> Hi Tom, >> >> On 11 October 2018 at 07:10, Tom Rini <trini@konsulko.com> wrote: >> > On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: >> > >> >> Hi Tom, >> >> >> >> Here is my attempt at a signed pull request. I've brought in most of the >> >> outstanding dm patches. Please let me know if it looks OK. Do you have my >> >> public key? >> > >> > Is it on the public key servers? >> >> Yes, here: >> >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium&op=index > > So yes, it is working. On your latest PR: > $ git show --show-signature > commit 1d6edcbfed2af33c748f2beb399810a0441888da > merged tag 'pull-14nov18' > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > 9008ADE6 > gpg: Good signature from "Simon Glass <sjg@chromium.org>" > Merge: f6206f8587fc 4c6e27f63c88 > Author: Tom Rini <trini@konsulko.com> > Date: Fri Nov 16 08:37:50 2018 -0500 > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > Thanks again! OK that's good to see, thanks! - SImon
Hi Tom, With this merge, my boards can't work correctly in SPL, the console output is mess up. I have test on rk3229 and rk3399 boards, and finally I identify that below patch is the root cause: 6f57c34473 serial: ns16550: fix debug uart putc called before init Thanks, - Kever On 11/16/2018 09:45 PM, Tom Rini wrote: > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: >> Hi Tom, >> >> On 11 October 2018 at 07:10, Tom Rini <trini@konsulko.com> wrote: >>> On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: >>> >>>> Hi Tom, >>>> >>>> Here is my attempt at a signed pull request. I've brought in most of the >>>> outstanding dm patches. Please let me know if it looks OK. Do you have my >>>> public key? >>> Is it on the public key servers? >> Yes, here: >> >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium&op=index > So yes, it is working. On your latest PR: > $ git show --show-signature > commit 1d6edcbfed2af33c748f2beb399810a0441888da > merged tag 'pull-14nov18' > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > 9008ADE6 > gpg: Good signature from "Simon Glass <sjg@chromium.org>" > Merge: f6206f8587fc 4c6e27f63c88 > Author: Tom Rini <trini@konsulko.com> > Date: Fri Nov 16 08:37:50 2018 -0500 > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > Thanks again! > > > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On Mon, Dec 3, 2018 at 8:27 AM Kever Yang <kever.yang@rock-chips.com> wrote: > > Hi Tom, > > With this merge, my boards can't work correctly in SPL, the console > output is mess up. > > I have test on rk3229 and rk3399 boards, and finally I identify that > below patch is the root cause: > > 6f57c34473 serial: ns16550: fix debug uart putc called before init Henri Roosen reported this to me last week. The root cause seems to be that the ns16550 baudrate prescaler is read as 0 on his rk3399 board. He helped me try an additional fix but that didn't work either. So we can either try and fix this if it is only a problem for rockchip boards or revert the patch and I'll think of a different solution to fix this issue (debug uart putc called before init) for the socfpga platform. I still think it would be good to fix this globally: there's nothing keeping us from accidentally adding putc code before the debug uart is initialized and this is something that should be detected, I think. Regards, Simon > > > Thanks, > - Kever > On 11/16/2018 09:45 PM, Tom Rini wrote: > > On Thu, Nov 15, 2018 at 06:05:05PM -0800, Simon Glass wrote: > >> Hi Tom, > >> > >> On 11 October 2018 at 07:10, Tom Rini <trini@konsulko.com> wrote: > >>> On Tue, Oct 09, 2018 at 06:24:13PM -0600, Simon Glass wrote: > >>> > >>>> Hi Tom, > >>>> > >>>> Here is my attempt at a signed pull request. I've brought in most of the > >>>> outstanding dm patches. Please let me know if it looks OK. Do you have my > >>>> public key? > >>> Is it on the public key servers? > >> Yes, here: > >> > >> https://pgp.mit.edu/pks/lookup?search=sjg%40chromium&op=index > > So yes, it is working. On your latest PR: > > $ git show --show-signature > > commit 1d6edcbfed2af33c748f2beb399810a0441888da > > merged tag 'pull-14nov18' > > gpg: Signature made Wed 14 Nov 2018 08:07:43 PM EST using RSA key ID > > 9008ADE6 > > gpg: Good signature from "Simon Glass <sjg@chromium.org>" > > Merge: f6206f8587fc 4c6e27f63c88 > > Author: Tom Rini <trini@konsulko.com> > > Date: Fri Nov 16 08:37:50 2018 -0500 > > > > Merge tag 'pull-14nov18' of git://git.denx.de/u-boot-dm > > > > Thanks again! > > > > > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
Hi. On Mon, 3 Dec 2018 at 00:42, Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: > > On Mon, Dec 3, 2018 at 8:27 AM Kever Yang <kever.yang@rock-chips.com> wrote: > > > > Hi Tom, > > > > With this merge, my boards can't work correctly in SPL, the console > > output is mess up. > > > > I have test on rk3229 and rk3399 boards, and finally I identify that > > below patch is the root cause: > > > > 6f57c34473 serial: ns16550: fix debug uart putc called before init > > Henri Roosen reported this to me last week. The root cause seems to be > that the ns16550 baudrate prescaler is read as 0 on his rk3399 board. > > He helped me try an additional fix but that didn't work either. > > So we can either try and fix this if it is only a problem for rockchip > boards or revert the patch and I'll think of a different solution to > fix this issue (debug uart putc called before init) for the socfpga > platform. > > I still think it would be good to fix this globally: there's nothing > keeping us from accidentally adding putc code before the debug uart is > initialized and this is something that should be detected, I think. I think it would be better to have this discussion on the patch rather than the pull request. Regards, Simon [..]