| Message ID | CAHa7zJOScc8eVmGPjWkV7LRFgxbvqyJPP75zcOMuFcR6kv_rnQ@mail.gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Kever Yang |
| Headers | show |
| Series | [U-Boot] Fix RK3328-evb Floating GPIO0_D6 - pull up - 4ma | expand |
Hi Mister, NAK for this patch. There is a dts for rock64 now. For the pinctrl, if this is a sdmmc IO, it would prefer to set the io in sdmmc node. One question is, the fix regulator driver should init this GPIO to LOW or HIGH as required which is not floating, does that not enough? Thanks, - Kever Mister Fix-IT <mrfixit2001@gmail.com> 于2019年5月11日周六 上午3:01写道： > Pin GPIO0_30 (D6) is left floating. In the case of the new revision of > Pine64 Rock64 Rev3, this pin needs to be pulled up 4ma. Otherwise > uboot fails to boot from sd stating "Card did not respond to voltage > select". > > --- > > arch/arm/dts/rk3328-evb.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/dts/rk3328-evb.dts b/arch/arm/dts/rk3328-evb.dts > index ec594a8452e..c242a8364c5 100644 > --- a/arch/arm/dts/rk3328-evb.dts > +++ b/arch/arm/dts/rk3328-evb.dts > @@ -25,6 +25,8 @@ > compatible = "regulator-fixed"; > regulator-name = "vcc3v3"; > gpio = <&gpio0 30 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sdmmc0m1_pwren>; > regulator-always-on; > regulator-boot-on; > }; > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot >
The fix will require pinctrl property for the regulator. Great that there is now a rock64 dts! In addition to the pinctrl, the gpio needs some muxing. Please see this later commit by ayufan which shows the required changes necessary: https://github.com/ayufan-rock64/linux-u-boot/commit/135bc82e76696c75600167c21ecf9c7efdd50bc2 On Fri, Jul 26, 2019 at 3:45 AM Kever Yang <kever.yang@rock-chips.com> wrote: > Hi Mister, > > NAK for this patch. > There is a dts for rock64 now. > For the pinctrl, if this is a sdmmc IO, it would prefer to set the io in > sdmmc node. > One question is, the fix regulator driver should init this GPIO to LOW or > HIGH > as required which is not floating, does that not enough? > > Thanks, > - Kever > > Mister Fix-IT <mrfixit2001@gmail.com> 于2019年5月11日周六 上午3:01写道： > >> Pin GPIO0_30 (D6) is left floating. In the case of the new revision of >> Pine64 Rock64 Rev3, this pin needs to be pulled up 4ma. Otherwise >> uboot fails to boot from sd stating "Card did not respond to voltage >> select". >> >> --- >> >> arch/arm/dts/rk3328-evb.dts | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/dts/rk3328-evb.dts b/arch/arm/dts/rk3328-evb.dts >> index ec594a8452e..c242a8364c5 100644 >> --- a/arch/arm/dts/rk3328-evb.dts >> +++ b/arch/arm/dts/rk3328-evb.dts >> @@ -25,6 +25,8 @@ >> compatible = "regulator-fixed"; >> regulator-name = "vcc3v3"; >> gpio = <&gpio0 30 GPIO_ACTIVE_LOW>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&sdmmc0m1_pwren>; >> regulator-always-on; >> regulator-boot-on; >> }; >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> https://lists.denx.de/listinfo/u-boot >> >
diff --git a/arch/arm/dts/rk3328-evb.dts b/arch/arm/dts/rk3328-evb.dts index ec594a8452e..c242a8364c5 100644 --- a/arch/arm/dts/rk3328-evb.dts +++ b/arch/arm/dts/rk3328-evb.dts @@ -25,6 +25,8 @@ compatible = "regulator-fixed"; regulator-name = "vcc3v3"; gpio = <&gpio0 30 GPIO_ACTIVE_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&sdmmc0m1_pwren>; regulator-always-on; regulator-boot-on; };