| Message ID | 92a4466d-f595-4ad9-a192-10950ca69b29@rwthex-w2-a.rwth-ad.de |
|---|---|
| State | Accepted |
| Commit | d1ccaa4760ae33fccad69cdbec4713c78d68a02e |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [U-Boot] patman: Unquote output from get_maintainer.pl | expand |
On 31 December 2017 at 15:21, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: > get_maintainer.pl quotes names which it considers unsafe, i.e. anything > containing [^a-zA-Z0-9_ \-]. This confuses patman, it will duplicate > addresses which are also in Series-to/cc. Strip the quotes. > > Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> > > --- > > tools/patman/get_maintainer.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 3 January 2018 at 09:42, Simon Glass <sjg@chromium.org> wrote: > On 31 December 2017 at 15:21, Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote: >> get_maintainer.pl quotes names which it considers unsafe, i.e. anything >> containing [^a-zA-Z0-9_ \-]. This confuses patman, it will duplicate >> addresses which are also in Series-to/cc. Strip the quotes. >> >> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> >> >> --- >> >> tools/patman/get_maintainer.py | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/tools/patman/get_maintainer.py b/tools/patman/get_maintainer.py index 2deb5db6ec..22b091808a 100644 --- a/tools/patman/get_maintainer.py +++ b/tools/patman/get_maintainer.py @@ -44,4 +44,5 @@ def GetMaintainer(fname, verbose=False): return [] stdout = command.Output(get_maintainer, '--norolestats', fname) - return stdout.splitlines() + lines = stdout.splitlines() + return [ x.replace('"', '') for x in lines ]
get_maintainer.pl quotes names which it considers unsafe, i.e. anything containing [^a-zA-Z0-9_ \-]. This confuses patman, it will duplicate addresses which are also in Series-to/cc. Strip the quotes. Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de> --- tools/patman/get_maintainer.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)