[U-Boot,0/6] Add support for the BK4R1 variant of PCM052

Hi Albert,

On 26/09/2016 09:08, Albert ARIBAUD (3ADEV) wrote:
> BK4R1 is basically PCM052 with the following differences
> or quirks:
> 
>   1) it has 512MB of DDR using MT41K256M16HA_125IT,
>      while the PCM052 has 256MB using MT41J128M16HA_15EIT;
> 
>   2) it has 1GB of NAND. The size increase is supported
>      by the env directly;
> 
>   3) its Ethernet ports are physicaly tied together until
>      GPIO 122 is raised. As this is a safety feature U-Boot
>      does not untie the ports except if it needs networking,
>      for instance when doing NAND updates via TFTP;
> 
>   4) it has a USB hub which may remain in reset if GPIO 130
>      is not raised. This is done unconditionally at boot;
> 
>   5) It has two NOR SPI flash chips on QSPI.
> 
> This series has been run through checkpatch and has no errors
> or warning except the following one:
> 
>         warning: arch/arm/Kconfig,681: please write a
>         paragraph that describes the config symbol fully
> 
> Which I believe does not apply, as target configs in this file
> never have descriptions.
> 
> 
> Albert ARIBAUD (3ADEV) (6):
>   pcm052: fix MTD partitioning
>   pcm052: remove target-specific dtb name from env
>   pcm052: add 'm4go' command
>   tools: mkimage: add support for Vybrid image format
>   pcm052: allow specifying onboard DDR size in configs
>   pcm052: add new BK4r1 target based on PCM052 SoM
> 
>  Makefile                          |   6 ++
>  arch/arm/Kconfig                  |   4 +
>  arch/arm/config.mk                |   3 +
>  arch/arm/cpu/armv7/vf610/Makefile |   5 +
>  arch/arm/dts/Makefile             |   3 +-
>  arch/arm/dts/bk4r1.dts            |  48 +++++++++
>  arch/arm/dts/vf.dtsi              |   4 +-
>  board/phytec/pcm052/Kconfig       |  24 +++++
>  board/phytec/pcm052/pcm052.c      | 206 ++++++++++++++++++++++++++++----------
>  common/image.c                    |   1 +
>  configs/bk4r1_defconfig           |  32 ++++++
>  include/configs/bk4r1.h           |  33 ++++++
>  include/configs/pcm052.h          |  78 ++++++++++-----
>  include/image.h                   |   1 +
>  tools/Makefile                    |   1 +
>  tools/vybridimage.c               | 164 ++++++++++++++++++++++++++++++
>  16 files changed, 535 insertions(+), 78 deletions(-)
>  create mode 100644 arch/arm/dts/bk4r1.dts
>  create mode 100644 configs/bk4r1_defconfig
>  create mode 100644 include/configs/bk4r1.h
>  create mode 100644 tools/vybridimage.c
> 

It looks like that CONFIG_CMD_UBI for bk4r1 is not set and I get build
errors. Is it ok for you if I add directly this by applying ?


Regards,
Stefano

Hi Stefano,

Le Thu, 6 Oct 2016 09:21:13 +0200, Stefano Babic <sbabic@denx.de> a
écrit :

> Hi Albert,
> 
> On 26/09/2016 09:08, Albert ARIBAUD (3ADEV) wrote:
> > BK4R1 is basically PCM052 with the following differences
> > or quirks:
> > 
> >   1) it has 512MB of DDR using MT41K256M16HA_125IT,
> >      while the PCM052 has 256MB using MT41J128M16HA_15EIT;
> > 
> >   2) it has 1GB of NAND. The size increase is supported
> >      by the env directly;
> > 
> >   3) its Ethernet ports are physicaly tied together until
> >      GPIO 122 is raised. As this is a safety feature U-Boot
> >      does not untie the ports except if it needs networking,
> >      for instance when doing NAND updates via TFTP;
> > 
> >   4) it has a USB hub which may remain in reset if GPIO 130
> >      is not raised. This is done unconditionally at boot;
> > 
> >   5) It has two NOR SPI flash chips on QSPI.
> > 
> > This series has been run through checkpatch and has no errors
> > or warning except the following one:
> > 
> >         warning: arch/arm/Kconfig,681: please write a
> >         paragraph that describes the config symbol fully
> > 
> > Which I believe does not apply, as target configs in this file
> > never have descriptions.
> > 
> > 
> > Albert ARIBAUD (3ADEV) (6):
> >   pcm052: fix MTD partitioning
> >   pcm052: remove target-specific dtb name from env
> >   pcm052: add 'm4go' command
> >   tools: mkimage: add support for Vybrid image format
> >   pcm052: allow specifying onboard DDR size in configs
> >   pcm052: add new BK4r1 target based on PCM052 SoM
> > 
> >  Makefile                          |   6 ++
> >  arch/arm/Kconfig                  |   4 +
> >  arch/arm/config.mk                |   3 +
> >  arch/arm/cpu/armv7/vf610/Makefile |   5 +
> >  arch/arm/dts/Makefile             |   3 +-
> >  arch/arm/dts/bk4r1.dts            |  48 +++++++++
> >  arch/arm/dts/vf.dtsi              |   4 +-
> >  board/phytec/pcm052/Kconfig       |  24 +++++
> >  board/phytec/pcm052/pcm052.c      | 206 ++++++++++++++++++++++++++++----------
> >  common/image.c                    |   1 +
> >  configs/bk4r1_defconfig           |  32 ++++++
> >  include/configs/bk4r1.h           |  33 ++++++
> >  include/configs/pcm052.h          |  78 ++++++++++-----
> >  include/image.h                   |   1 +
> >  tools/Makefile                    |   1 +
> >  tools/vybridimage.c               | 164 ++++++++++++++++++++++++++++++
> >  16 files changed, 535 insertions(+), 78 deletions(-)
> >  create mode 100644 arch/arm/dts/bk4r1.dts
> >  create mode 100644 configs/bk4r1_defconfig
> >  create mode 100644 include/configs/bk4r1.h
> >  create mode 100644 tools/vybridimage.c
> >   
> 
> It looks like that CONFIG_CMD_UBI for bk4r1 is not set and I get build
> errors.

Hmm... What U-Boot commit do you apply above?

> Is it ok for you if I add directly this by applying ?

I'll check this and let you know later today.

> diff --git a/configs/bk4r1_defconfig b/configs/bk4r1_defconfig
> index 3994459..26d9e81 100644
> --- a/configs/bk4r1_defconfig
> +++ b/configs/bk4r1_defconfig
> @@ -30,3 +30,4 @@ CONFIG_SPI_FLASH=y
>  CONFIG_SPI_FLASH_STMICRO=y
>  CONFIG_SPI_FLASH_MTD=y
>  CONFIG_CMD_DM=y
> +CONFIG_CMD_UBI=y
> 
> Regards,
> Stefano
> 



Cordialement,
Albert ARIBAUD
3ADEV

Hi Albert,

On 06/10/2016 15:43, Albert ARIBAUD wrote:

> 
> Hmm... What U-Boot commit do you apply above?

It was on top of v2016.11-rc1, and then I have already applied several
patches for i.MX.

I am very sorry for that: generally, I check the patches in a separate
local branch, but it seemed I made a mistake and I have applied it on my
-master, and after my last push they are already on the server. It was
not my intention. Of course, I will revert them back if you do not like
/ disagree.

> 
>> Is it ok for you if I add directly this by applying ?
> 
> I'll check this and let you know later today.
> 

Thanks !

Stefano

Hi Stefano,

Sorry for the delay.

Le Fri, 7 Oct 2016 12:01:02 +0200, Stefano Babic <sbabic@denx.de> a
écrit :

> Hi Albert,
> 
> On 06/10/2016 15:43, Albert ARIBAUD wrote:
> 
> > 
> > Hmm... What U-Boot commit do you apply above?  
> 
> It was on top of v2016.11-rc1, and then I have already applied several
> patches for i.MX.
> 
> I am very sorry for that: generally, I check the patches in a separate
> local branch, but it seemed I made a mistake and I have applied it on my
> -master, and after my last push they are already on the server. It was
> not my intention. Of course, I will revert them back if you do not like
> / disagree.

No problem.

I could not reproduce the problem on my side (i.e., origin/master
buildman builds bk4r1 without any warning or error), but anyway, your
change appears harmless enough, so I'm fine with you adding it.

Thanks!

Cordialement,
Albert ARIBAUD
3ADEV