diff mbox

[U-Boot] fs: usbifs: Fix warning in ubifs

Message ID 854c3261ff41183566d44728b6a8e604e3f14980.1496147344.git.michal.simek@xilinx.com
State Accepted
Commit 34cc30af27165696a36274394f6ff019ed762ce6
Delegated to: Heiko Schocher
Headers show

Commit Message

Michal Simek May 30, 2017, 12:29 p.m. UTC
From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>

This patch fixes the below warning by typecasting it properly
fs/ubifs/ubifs.c: In function 'ubifs_load':
fs/ubifs/ubifs.c:942:29: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
  err = ubifs_read(filename, (void *)addr, 0, size, &actread);

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 fs/ubifs/ubifs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Schocher June 6, 2017, 5:10 a.m. UTC | #1
Hello Michal,

Am 30.05.2017 um 14:29 schrieb Michal Simek:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
>
> This patch fixes the below warning by typecasting it properly
> fs/ubifs/ubifs.c: In function 'ubifs_load':
> fs/ubifs/ubifs.c:942:29: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cast]
>    err = ubifs_read(filename, (void *)addr, 0, size, &actread);
>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>   fs/ubifs/ubifs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
> index cc397d605b0e..db29489eca75 100644
> --- a/fs/ubifs/ubifs.c
> +++ b/fs/ubifs/ubifs.c
> @@ -939,7 +939,7 @@ int ubifs_load(char *filename, u32 addr, u32 size)
>
>   	printf("Loading file '%s' to addr 0x%08x...\n", filename, addr);
>
> -	err = ubifs_read(filename, (void *)addr, 0, size, &actread);
> +	err = ubifs_read(filename, (void *)(uintptr_t)addr, 0, size, &actread);
>   	if (err == 0) {
>   		setenv_hex("filesize", actread);
>   		printf("Done\n");
>
diff mbox

Patch

diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
index cc397d605b0e..db29489eca75 100644
--- a/fs/ubifs/ubifs.c
+++ b/fs/ubifs/ubifs.c
@@ -939,7 +939,7 @@  int ubifs_load(char *filename, u32 addr, u32 size)
 
 	printf("Loading file '%s' to addr 0x%08x...\n", filename, addr);
 
-	err = ubifs_read(filename, (void *)addr, 0, size, &actread);
+	err = ubifs_read(filename, (void *)(uintptr_t)addr, 0, size, &actread);
 	if (err == 0) {
 		setenv_hex("filesize", actread);
 		printf("Done\n");