| Message ID | 83634bb5ffff308a693021bf2729742c0b30b2cc.1576893816.git.tommyhebb@gmail.com |
|---|---|
| State | Accepted |
| Commit | 541911f479bf68079269d2716589c0cc0ee732ff |
| Delegated to: | Patrick Delaunay |
| Headers | show |
| Series | stm32mp: remove redundant SYS_TEXT_BASE prompt | expand |
Hi Thomas, > From: Thomas Hebb <tommyhebb@gmail.com> > Sent: samedi 21 décembre 2019 03:04 > > The main prompt for this (defined in /Kconfig) is visible at all times, which means > there's no reason to have an additional, machine-specific prompt to set the same > option. > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com> Yes, thanks for notice it. It wasn't the case before the commit 278b90ce786f ('configs: Migrate CONFIG_SYS_TEXT_BASE') merged before my first comit 2514c2d0e6abe (' arm: stm32: add new architecture for STM32MP family'). And I miss it when I rebase my initial serie. Acked-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > arch/arm/mach-stm32mp/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig > index ae28f6e206..bf8a18a0c3 100644 > --- a/arch/arm/mach-stm32mp/Kconfig > +++ b/arch/arm/mach-stm32mp/Kconfig > @@ -80,12 +80,7 @@ config STM32MP1_OPTEE > OP-TEE monitor provides ST SMC to access to secure resources > > config SYS_TEXT_BASE > - prompt "U-Boot base address" > default 0xC0100000 > - help > - configure the U-Boot base address > - when DDR driver is used: > - DDR + 1MB (0xC0100000) > > config NR_DRAM_BANKS > default 1 > -- > 2.24.1
Hi Thomas, > From: Uboot-stm32 <uboot-stm32-bounces@st-md-mailman.stormreply.com> On > Behalf Of Thomas Hebb > > The main prompt for this (defined in /Kconfig) is visible at all times, which means > there's no reason to have an additional, machine-specific prompt to set the same > option. > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com> > --- Acked-by: Patrick Delaunay <patrick.delaunay@st.com> Applied to u-boot-stm32/master, thanks! Regards Patrick
diff --git a/arch/arm/mach-stm32mp/Kconfig b/arch/arm/mach-stm32mp/Kconfig index ae28f6e206..bf8a18a0c3 100644 --- a/arch/arm/mach-stm32mp/Kconfig +++ b/arch/arm/mach-stm32mp/Kconfig @@ -80,12 +80,7 @@ config STM32MP1_OPTEE OP-TEE monitor provides ST SMC to access to secure resources config SYS_TEXT_BASE - prompt "U-Boot base address" default 0xC0100000 - help - configure the U-Boot base address - when DDR driver is used: - DDR + 1MB (0xC0100000) config NR_DRAM_BANKS default 1
The main prompt for this (defined in /Kconfig) is visible at all times, which means there's no reason to have an additional, machine-specific prompt to set the same option. Signed-off-by: Thomas Hebb <tommyhebb@gmail.com> --- arch/arm/mach-stm32mp/Kconfig | 5 ----- 1 file changed, 5 deletions(-)