diff mbox

[U-Boot] OMAP4: Broken SPL generation

Message ID 4E3C3C4D.2000104@googlemail.com
State Not Applicable
Delegated to: Tom Rini
Headers show

Commit Message

Dirk Behme Aug. 5, 2011, 6:54 p.m. UTC
Building the SPL for omap4_sdp4430 and omap4_panda in recent mainline 
is broken due to a resulting image size > 32k:

Configuring for omap4_sdp4430 board...
arm-none-linux-gnueabi-ld: u-boot-spl section .rodata will not fit in 
region .sram
arm-none-linux-gnueabi-ld: region .sram overflowed by 612 bytes

Configuring for omap4_panda board...
arm-none-linux-gnueabi-ld: u-boot-spl section .rodata will not fit in 
region .sram
arm-none-linux-gnueabi-ld: region .sram overflowed by 620 bytes

This seems to come from the the patch "omap: add MMC and FAT support 
to SPL" [1] adding a lot of code to the SPL.

Does anybody have a quick solution for this fixing the build of these 
boards for the -rc cycle? Else I'm about to send a patch like [2] 
disabling the SPL build until a patch to reduce the image size is 
available.

Best regards

Dirk

[1] 
http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commit;h=8cf686e19b6922a2a6b401af188dfb83414c3c04

[2]
  include/configs/omap4_panda.h   |    2 +-
  include/configs/omap4_sdp4430.h |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Albert ARIBAUD Aug. 7, 2011, 9:50 a.m. UTC | #1
Hi Dirk,

Le 05/08/2011 20:54, Dirk Behme a écrit :

> Does anybody have a quick solution for this fixing the build of these
> boards for the -rc cycle? Else I'm about to send a patch like [2]
> disabling the SPL build until a patch to reduce the image size is
> available.

> [2]
>    include/configs/omap4_panda.h   |    2 +-
>    include/configs/omap4_sdp4430.h |    2 +-
>    2 files changed, 2 insertions(+), 2 deletions(-)
>    [...]

Just a side note: that's the second time someone quotes a patch or part 
of patch in a mail not intended to be a patch submission, only patchwork 
mistakenly takes it as a proper patch submission and either creates an 
unwanted patch entry or even worse, breaks the discussion on an original 
patch

Maybe a good habit to keep in mind is to only quote the true diff part 
of the patch or to actually quote it (with "> " prepended).

Amicalement,
Aneesh V Aug. 8, 2011, 5:56 a.m. UTC | #2
Hi Dirk,

I can fix it. We have more SRAM available in 4430. I can increase the
SRAM budget. I will send a patch shortly.

br,
Aneesh

On Saturday 06 August 2011 12:24 AM, Dirk Behme wrote:
>
> Building the SPL for omap4_sdp4430 and omap4_panda in recent mainline is
> broken due to a resulting image size > 32k:
>
> Configuring for omap4_sdp4430 board...
> arm-none-linux-gnueabi-ld: u-boot-spl section .rodata will not fit in
> region .sram
> arm-none-linux-gnueabi-ld: region .sram overflowed by 612 bytes
>
> Configuring for omap4_panda board...
> arm-none-linux-gnueabi-ld: u-boot-spl section .rodata will not fit in
> region .sram
> arm-none-linux-gnueabi-ld: region .sram overflowed by 620 bytes
>
> This seems to come from the the patch "omap: add MMC and FAT support to
> SPL" [1] adding a lot of code to the SPL.
>
> Does anybody have a quick solution for this fixing the build of these
> boards for the -rc cycle? Else I'm about to send a patch like [2]
> disabling the SPL build until a patch to reduce the image size is
> available.
>
> Best regards
>
> Dirk
>
> [1]
> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commit;h=8cf686e19b6922a2a6b401af188dfb83414c3c04
>
>
> [2]
> include/configs/omap4_panda.h | 2 +-
> include/configs/omap4_sdp4430.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Index: u-boot.git/include/configs/omap4_panda.h
> ===================================================================
> --- u-boot.git.orig/include/configs/omap4_panda.h
> +++ u-boot.git/include/configs/omap4_panda.h
> @@ -243,7 +243,7 @@
> #endif
>
> /* Defines for SPL */
> -#define CONFIG_SPL
> +//#define CONFIG_SPL
> #define CONFIG_SPL_TEXT_BASE 0x40304350
> #define CONFIG_SPL_MAX_SIZE 0x8000 /* 32 K */
> #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
> Index: u-boot.git/include/configs/omap4_sdp4430.h
> ===================================================================
> --- u-boot.git.orig/include/configs/omap4_sdp4430.h
> +++ u-boot.git/include/configs/omap4_sdp4430.h
> @@ -249,7 +249,7 @@
> #endif
>
> /* Defines for SPL */
> -#define CONFIG_SPL
> +//#define CONFIG_SPL
> #define CONFIG_SPL_TEXT_BASE 0x40304350
> #define CONFIG_SPL_MAX_SIZE 0x8000 /* 32 K */
> #define CONFIG_SPL_STACK LOW_LEVEL_SRAM_STACK
>
diff mbox

Patch

Index: u-boot.git/include/configs/omap4_panda.h
===================================================================
--- u-boot.git.orig/include/configs/omap4_panda.h
+++ u-boot.git/include/configs/omap4_panda.h
@@ -243,7 +243,7 @@ 
  #endif

  /* Defines for SPL */
-#define CONFIG_SPL
+//#define CONFIG_SPL
  #define CONFIG_SPL_TEXT_BASE		0x40304350
  #define CONFIG_SPL_MAX_SIZE		0x8000	/* 32 K */
  #define CONFIG_SPL_STACK		LOW_LEVEL_SRAM_STACK
Index: u-boot.git/include/configs/omap4_sdp4430.h
===================================================================
--- u-boot.git.orig/include/configs/omap4_sdp4430.h
+++ u-boot.git/include/configs/omap4_sdp4430.h
@@ -249,7 +249,7 @@ 
  #endif

  /* Defines for SPL */
-#define CONFIG_SPL
+//#define CONFIG_SPL
  #define CONFIG_SPL_TEXT_BASE		0x40304350
  #define CONFIG_SPL_MAX_SIZE		0x8000	/* 32 K */
  #define CONFIG_SPL_STACK		LOW_LEVEL_SRAM_STACK