| Message ID | 47d7bdbb86a241c8b61efba8cad97de4dca40eb5.1578579516.git.michal.simek@xilinx.com |
|---|---|
| State | Accepted |
| Commit | 8e3501ec900f8cab490345003b9bb9ed425fe2f8 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | xilinx: Various DT changes and syncups | expand |
On Thu, Jan 9, 2020 at 11:19 PM Michal Simek <michal.simek@xilinx.com> wrote: > > From: Rob Herring <robh@kernel.org> > > The 'arm,armv8' compatible string is only for software models. It adds > little value otherwise and is inconsistently used as a fallback on some > platforms. Remove it from those platforms. > > This fixes warnings generated by the DT schema. > > Reported-by: Michal Simek <michal.simek@xilinx.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Acked-by: Antoine Tenart <antoine.tenart@bootlin.com> > Acked-by: Nishanth Menon <nm@ti.com> > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Acked-by: Chanho Min <chanho.min@lge.com> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Heiko Stuebner <heiko@sntech.de> > Acked-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Tero Kristo <t-kristo@ti.com> > Acked-by: Wei Xu <xuwei5@hisilicon.com> > Acked-by: Liviu Dudau <liviu.dudau@arm.com> > Acked-by: Matthias Brugger <matthias.bgg@gmail.com> > Acked-by: Michal Simek <michal.simek@xilinx.com> > Acked-by: Scott Branden <scott.branden@broadcom.com> > Acked-by: Kevin Hilman <khilman@baylibre.com> > Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> > Acked-by: Robert Richter <rrichter@cavium.com> > Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> > Acked-by: Dinh Nguyen <dinguyen@kernel.org> I know you are importing this commit from Linux, but these Ack lines look weird to me... > Signed-off-by: Rob Herring <robh@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > arch/arm/dts/zynqmp.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/dts/zynqmp.dtsi b/arch/arm/dts/zynqmp.dtsi > index b453941baf05..8646c4c3a340 100644 > --- a/arch/arm/dts/zynqmp.dtsi > +++ b/arch/arm/dts/zynqmp.dtsi > @@ -25,7 +25,7 @@ > #size-cells = <0>; > > cpu0: cpu@0 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "psci"; > operating-points-v2 = <&cpu_opp_table>; > @@ -34,7 +34,7 @@ > }; > > cpu1: cpu@1 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "psci"; > reg = <0x1>; > @@ -43,7 +43,7 @@ > }; > > cpu2: cpu@2 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "psci"; > reg = <0x2>; > @@ -52,7 +52,7 @@ > }; > > cpu3: cpu@3 { > - compatible = "arm,cortex-a53", "arm,armv8"; > + compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "psci"; > reg = <0x3>; > -- > 2.24.0 >
On 10. 01. 20 16:36, Masahiro Yamada wrote: > On Thu, Jan 9, 2020 at 11:19 PM Michal Simek <michal.simek@xilinx.com> wrote: >> >> From: Rob Herring <robh@kernel.org> >> >> The 'arm,armv8' compatible string is only for software models. It adds >> little value otherwise and is inconsistently used as a fallback on some >> platforms. Remove it from those platforms. >> >> This fixes warnings generated by the DT schema. >> >> Reported-by: Michal Simek <michal.simek@xilinx.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Will Deacon <will.deacon@arm.com> >> Acked-by: Antoine Tenart <antoine.tenart@bootlin.com> >> Acked-by: Nishanth Menon <nm@ti.com> >> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> >> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> Acked-by: Chanho Min <chanho.min@lge.com> >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> >> Acked-by: Thierry Reding <treding@nvidia.com> >> Acked-by: Heiko Stuebner <heiko@sntech.de> >> Acked-by: Simon Horman <horms+renesas@verge.net.au> >> Acked-by: Tero Kristo <t-kristo@ti.com> >> Acked-by: Wei Xu <xuwei5@hisilicon.com> >> Acked-by: Liviu Dudau <liviu.dudau@arm.com> >> Acked-by: Matthias Brugger <matthias.bgg@gmail.com> >> Acked-by: Michal Simek <michal.simek@xilinx.com> >> Acked-by: Scott Branden <scott.branden@broadcom.com> >> Acked-by: Kevin Hilman <khilman@baylibre.com> >> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> >> Acked-by: Robert Richter <rrichter@cavium.com> >> Acked-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> >> Acked-by: Dinh Nguyen <dinguyen@kernel.org> > > > I know you are importing this commit from Linux, > but these Ack lines look weird to me... I have not a problem to remove them but not sure if this is the right thing to do. Thanks, Michal
diff --git a/arch/arm/dts/zynqmp.dtsi b/arch/arm/dts/zynqmp.dtsi index b453941baf05..8646c4c3a340 100644 --- a/arch/arm/dts/zynqmp.dtsi +++ b/arch/arm/dts/zynqmp.dtsi @@ -25,7 +25,7 @@ #size-cells = <0>; cpu0: cpu@0 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; device_type = "cpu"; enable-method = "psci"; operating-points-v2 = <&cpu_opp_table>; @@ -34,7 +34,7 @@ }; cpu1: cpu@1 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; device_type = "cpu"; enable-method = "psci"; reg = <0x1>; @@ -43,7 +43,7 @@ }; cpu2: cpu@2 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; device_type = "cpu"; enable-method = "psci"; reg = <0x2>; @@ -52,7 +52,7 @@ }; cpu3: cpu@3 { - compatible = "arm,cortex-a53", "arm,armv8"; + compatible = "arm,cortex-a53"; device_type = "cpu"; enable-method = "psci"; reg = <0x3>;