Message ID | 4170d786-064b-045e-533f-94e389a5a6a4@denx.de |
---|---|
State | Not Applicable |
Delegated to: | Stefano Babic |
Headers | show |
Hi Stefano, On Mon, Oct 24, 2016 at 04:05:53PM +0200, Stefano Babic wrote: >Hi Peng, > >On 11/10/2016 08:29, Peng Fan wrote: >> Add plugin support for imximage. >> >> Define CONFIG_USE_IMXIMG_PLUGIN in defconfig to enable using plugin. >> >> Signed-off-by: Peng Fan <peng.fan@nxp.com> >> Cc: Stefano Babic <sbabic@denx.de> >> Cc: Eric Nelson <eric@nelint.com> >> Cc: Ye Li <ye.li@nxp.com> >> Reviewed-by: Tom Rini <trini@konsulko.com> >> --- >> > >I have just the same issue as with Jagan's patches. Due to recent >changes, we need to unset a couple of defines in defconfig (ull without >plugin is already fixed). > >This means: > >diff --git a/configs/mx6ull_14x14_evk_plugin_defconfig >b/configs/mx6ull_14x14_evk_plugin_defconfig >index ff15c8e..095e48d 100644 >--- a/configs/mx6ull_14x14_evk_plugin_defconfig >+++ b/configs/mx6ull_14x14_evk_plugin_defconfig >@@ -25,6 +25,8 @@ CONFIG_DM_GPIO=y > CONFIG_DM_74X164=y > CONFIG_DM_I2C=y > CONFIG_DM_MMC=y >+# CONFIG_BLK is not set >+# CONFIG_DM_MMC_OPS is not set > CONFIG_PINCTRL=y > CONFIG_PINCTRL_IMX6=y > CONFIG_DM_REGULATOR=y > > >If you agree, I will make the change by applying it. Yeah. Please help do this. Thanks, Peng.
On 25/10/2016 02:09, Peng Fan wrote: > Hi Stefano, > On Mon, Oct 24, 2016 at 04:05:53PM +0200, Stefano Babic wrote: >> Hi Peng, >> >> On 11/10/2016 08:29, Peng Fan wrote: >>> Add plugin support for imximage. >>> >>> Define CONFIG_USE_IMXIMG_PLUGIN in defconfig to enable using plugin. >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> Cc: Stefano Babic <sbabic@denx.de> >>> Cc: Eric Nelson <eric@nelint.com> >>> Cc: Ye Li <ye.li@nxp.com> >>> Reviewed-by: Tom Rini <trini@konsulko.com> >>> --- >>> >> >> I have just the same issue as with Jagan's patches. Due to recent >> changes, we need to unset a couple of defines in defconfig (ull without >> plugin is already fixed). >> >> This means: >> >> diff --git a/configs/mx6ull_14x14_evk_plugin_defconfig >> b/configs/mx6ull_14x14_evk_plugin_defconfig >> index ff15c8e..095e48d 100644 >> --- a/configs/mx6ull_14x14_evk_plugin_defconfig >> +++ b/configs/mx6ull_14x14_evk_plugin_defconfig >> @@ -25,6 +25,8 @@ CONFIG_DM_GPIO=y >> CONFIG_DM_74X164=y >> CONFIG_DM_I2C=y >> CONFIG_DM_MMC=y >> +# CONFIG_BLK is not set >> +# CONFIG_DM_MMC_OPS is not set >> CONFIG_PINCTRL=y >> CONFIG_PINCTRL_IMX6=y >> CONFIG_DM_REGULATOR=y >> >> >> If you agree, I will make the change by applying it. > > Yeah. Please help do this. ok, thanks - applied to master. Best regards, Stefano Babic
diff --git a/configs/mx6ull_14x14_evk_plugin_defconfig b/configs/mx6ull_14x14_evk_plugin_defconfig index ff15c8e..095e48d 100644 --- a/configs/mx6ull_14x14_evk_plugin_defconfig +++ b/configs/mx6ull_14x14_evk_plugin_defconfig @@ -25,6 +25,8 @@ CONFIG_DM_GPIO=y CONFIG_DM_74X164=y CONFIG_DM_I2C=y CONFIG_DM_MMC=y +# CONFIG_BLK is not set +# CONFIG_DM_MMC_OPS is not set CONFIG_PINCTRL=y CONFIG_PINCTRL_IMX6=y CONFIG_DM_REGULATOR=y