diff mbox

[U-Boot,v3] serial: zynq: Use static inline for _debug_uart_init()

Message ID 38b85d7d53321d2ff8f4d6182a102dea54abbf6e.1451994551.git.michal.simek@xilinx.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Michal Simek Jan. 5, 2016, 11:49 a.m. UTC
Mark _debug_uart_init() as static to avoid sparse warning and
inline it to debug_uart_init().

Reported-by: Thomas Chou <thomas@wytron.com.tw>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Thomas Chou <thomas@wytron.com.tw>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v3:
- Separate uartlite from this patch

Changes in v2:
- Add tags
- Extend commit message reported by Bin

 drivers/serial/serial_zynq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Jan. 6, 2016, 12:24 a.m. UTC | #1
On 5 January 2016 at 04:49, Michal Simek <michal.simek@xilinx.com> wrote:
> Mark _debug_uart_init() as static to avoid sparse warning and
> inline it to debug_uart_init().
>
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Thomas Chou <thomas@wytron.com.tw>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v3:
> - Separate uartlite from this patch
>
> Changes in v2:
> - Add tags
> - Extend commit message reported by Bin
>
>  drivers/serial/serial_zynq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 9, 2016, 3:35 a.m. UTC | #2
On Tue, Jan 05, 2016 at 12:49:21PM +0100, Michal Simek wrote:

> Mark _debug_uart_init() as static to avoid sparse warning and
> inline it to debug_uart_init().
> 
> Reported-by: Thomas Chou <thomas@wytron.com.tw>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Thomas Chou <thomas@wytron.com.tw>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/serial/serial_zynq.c b/drivers/serial/serial_zynq.c
index b2b98dea1561..3430482f8d8b 100644
--- a/drivers/serial/serial_zynq.c
+++ b/drivers/serial/serial_zynq.c
@@ -192,7 +192,7 @@  U_BOOT_DRIVER(serial_zynq) = {
 };
 
 #ifdef CONFIG_DEBUG_UART_ZYNQ
-void _debug_uart_init(void)
+static inline void _debug_uart_init(void)
 {
 	struct uart_zynq *regs = (struct uart_zynq *)CONFIG_DEBUG_UART_BASE;