| Message ID | 380f0990caf53de80a38053de690b1f8777941e8.1529571836.git.baruch@tkos.co.il |
|---|---|
| State | Superseded |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | [U-Boot] arm: mvebu: clearfog: add u-boot, dm-spl tag for spi | expand |
Hi Baruch, On 21.06.2018 11:03, Baruch Siach wrote: > From: Jon Nettleton <jon@solid-run.com> > > This is required so SPL and u-boot can boot from spi > flash devices that use the dm drivers. > > Signed-off-by: Jon Nettleton <jon@solid-run.com> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > arch/arm/dts/armada-388-clearfog.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/dts/armada-388-clearfog.dts b/arch/arm/dts/armada-388-clearfog.dts > index a0b566a5ae0e..b219441d84be 100644 > --- a/arch/arm/dts/armada-388-clearfog.dts > +++ b/arch/arm/dts/armada-388-clearfog.dts > @@ -342,6 +342,7 @@ > pinctrl-0 = <&spi1_pins &clearfog_spi1_cs_pins &mikro_spi_pins>; > pinctrl-names = "default"; > status = "okay"; > + u-boot,dm-spl; > > spi-flash@0 { > #address-cells = <1>; > @@ -349,6 +350,7 @@ > compatible = "w25q32", "jedec,spi-nor", "spi-flash"; > reg = <0>; /* Chip select 0 */ > spi-max-frequency = <3000000>; > + u-boot,dm-spl; > }; > }; > > Yes, this is necessary. I failed to do this until now, but we should stop adding U-Boot specific properties into the DT source files. There is a way to add such properties in a better manner - not breaking the compatibility with the original Linux DT sources, so that they can be included 1:1 - without any changes. Please use the "*-u-boot.dtsi" file for this. Here an example: arch/arm/dts/armada-385-turris-omnia-u-boot.dtsi If this file with the "-u-boot.dtsi" extension exists, it will be included automatically in the build process. Please give it a try and change to using this style in the next version. Thanks, Stefan
diff --git a/arch/arm/dts/armada-388-clearfog.dts b/arch/arm/dts/armada-388-clearfog.dts index a0b566a5ae0e..b219441d84be 100644 --- a/arch/arm/dts/armada-388-clearfog.dts +++ b/arch/arm/dts/armada-388-clearfog.dts @@ -342,6 +342,7 @@ pinctrl-0 = <&spi1_pins &clearfog_spi1_cs_pins &mikro_spi_pins>; pinctrl-names = "default"; status = "okay"; + u-boot,dm-spl; spi-flash@0 { #address-cells = <1>; @@ -349,6 +350,7 @@ compatible = "w25q32", "jedec,spi-nor", "spi-flash"; reg = <0>; /* Chip select 0 */ spi-max-frequency = <3000000>; + u-boot,dm-spl; }; };