| Message ID | 352020a574eb12267bdaee0efa48e5b2075c9ae0.1478621974.git-series.maxime.ripard@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | ff93c2826565e5140b8c9d6826da0b79531645f2 |
| Delegated to: | Hans de Goede |
| Headers | show |
On Tue, 8 Nov 2016 17:21:15 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The SPL image needs to be built with a different ECC configuration than the > U-Boot binary. > > Add Kconfig options with defaults to provide a value that should work for > anyone, but is still configurable if needs be. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/mtd/nand/Kconfig | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index df154bfd32b9..a60abb625ee5 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -73,6 +73,22 @@ config NAND_SUNXI > The SPL driver only supports reading from the NAND using DMA > transfers. > > +if NAND_SUNXI > + > +config NAND_SUNXI_SPL_ECC_STRENGTH > + int "Allwinner NAND SPL ECC Strength" > + default 64 > + > +config NAND_SUNXI_SPL_ECC_SIZE > + int "Allwinner NAND SPL ECC Step Size" > + default 1024 > + > +config NAND_SUNXI_SPL_USABLE_PAGE_SIZE > + int "Allwinner NAND SPL Usable Page Size" > + default 1024 > + > +endif > + > config NAND_ARASAN > bool "Configure Arasan Nand" > help
Hi, On 08-11-16 17:21, Maxime Ripard wrote: > The SPL image needs to be built with a different ECC configuration than the > U-Boot binary. > > Add Kconfig options with defaults to provide a value that should work for > anyone, but is still configurable if needs be. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/mtd/nand/Kconfig | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index df154bfd32b9..a60abb625ee5 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -73,6 +73,22 @@ config NAND_SUNXI > The SPL driver only supports reading from the NAND using DMA > transfers. > > +if NAND_SUNXI > + > +config NAND_SUNXI_SPL_ECC_STRENGTH > + int "Allwinner NAND SPL ECC Strength" > + default 64 > + > +config NAND_SUNXI_SPL_ECC_SIZE > + int "Allwinner NAND SPL ECC Step Size" > + default 1024 > + > +config NAND_SUNXI_SPL_USABLE_PAGE_SIZE > + int "Allwinner NAND SPL Usable Page Size" > + default 1024 > + > +endif > + > config NAND_ARASAN > bool "Configure Arasan Nand" > help >
On Tue, 2016-11-08 at 17:21 +0100, Maxime Ripard wrote: > The SPL image needs to be built with a different ECC configuration than the > U-Boot binary. > > Add Kconfig options with defaults to provide a value that should work for > anyone, but is still configurable if needs be. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/mtd/nand/Kconfig | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+), 0 deletions(-) Acked-by: Scott Wood <oss@buserror.net> -Scott
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index df154bfd32b9..a60abb625ee5 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -73,6 +73,22 @@ config NAND_SUNXI The SPL driver only supports reading from the NAND using DMA transfers. +if NAND_SUNXI + +config NAND_SUNXI_SPL_ECC_STRENGTH + int "Allwinner NAND SPL ECC Strength" + default 64 + +config NAND_SUNXI_SPL_ECC_SIZE + int "Allwinner NAND SPL ECC Step Size" + default 1024 + +config NAND_SUNXI_SPL_USABLE_PAGE_SIZE + int "Allwinner NAND SPL Usable Page Size" + default 1024 + +endif + config NAND_ARASAN bool "Configure Arasan Nand" help
The SPL image needs to be built with a different ECC configuration than the U-Boot binary. Add Kconfig options with defaults to provide a value that should work for anyone, but is still configurable if needs be. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/mtd/nand/Kconfig | 16 ++++++++++++++++ 1 file changed, 16 insertions(+), 0 deletions(-)