diff mbox series

mips: mt7688: gardena-smart-gateway: Increase CONFIG_SYS_BOOTM_LEN

Message ID 20241023132731.420801-1-ezra@easyb.ch
State New
Delegated to: Daniel Schwierzeck
Headers show
Series mips: mt7688: gardena-smart-gateway: Increase CONFIG_SYS_BOOTM_LEN | expand

Commit Message

Ezra Buehler Oct. 23, 2024, 1:27 p.m. UTC 
From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

The default value of 0x800000 (8 MB) is somewhat limiting for us, as our
compressed kernel may grow up to around 4 MB. By choosing the commonly
used value of 0x2000000 (32 MB), we are definitely on the safe side.
This rather large amount should be fine, as we have 128 MB of RAM.

Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
---

Are there drawbacks of choosing a hight value for CONFIG_SYS_BOOTM_LEN
that I am missing here? If so, 0x1000000 is most likely enough too.

Cheers,
Ezra.

 configs/gardena-smart-gateway-mt7688_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Roese Oct. 23, 2024, 1:48 p.m. UTC | #1 
On 10/23/24 15:27, Ezra Buehler wrote:
> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> 
> The default value of 0x800000 (8 MB) is somewhat limiting for us, as our
> compressed kernel may grow up to around 4 MB. By choosing the commonly
> used value of 0x2000000 (32 MB), we are definitely on the safe side.
> This rather large amount should be fine, as we have 128 MB of RAM.
> 
> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> ---
> 
> Are there drawbacks of choosing a hight value for CONFIG_SYS_BOOTM_LEN
> that I am missing here? If so, 0x1000000 is most likely enough too.

I don't see problems with using 32MB, so:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> Cheers,
> Ezra.
> 
>   configs/gardena-smart-gateway-mt7688_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/gardena-smart-gateway-mt7688_defconfig b/configs/gardena-smart-gateway-mt7688_defconfig
> index b7f4a76ce6..2c69e91339 100644
> --- a/configs/gardena-smart-gateway-mt7688_defconfig
> +++ b/configs/gardena-smart-gateway-mt7688_defconfig
> @@ -47,6 +47,7 @@ CONFIG_SPL_SYS_MALLOC_SIMPLE=y
>   CONFIG_SPL_NOR_SUPPORT=y
>   CONFIG_HUSH_PARSER=y
>   CONFIG_CMD_LICENSE=y
> +CONFIG_SYS_BOOTM_LEN=0x2000000
>   # CONFIG_CMD_ELF is not set
>   # CONFIG_CMD_XIMG is not set
>   CONFIG_CMD_MEMINFO=y

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/configs/gardena-smart-gateway-mt7688_defconfig b/configs/gardena-smart-gateway-mt7688_defconfig
index b7f4a76ce6..2c69e91339 100644
--- a/configs/gardena-smart-gateway-mt7688_defconfig
+++ b/configs/gardena-smart-gateway-mt7688_defconfig
@@ -47,6 +47,7 @@  CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_SPL_NOR_SUPPORT=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_LICENSE=y
+CONFIG_SYS_BOOTM_LEN=0x2000000
 # CONFIG_CMD_ELF is not set
 # CONFIG_CMD_XIMG is not set
 CONFIG_CMD_MEMINFO=y