| Message ID | 20240527061504.19822-1-ilias.apalodimas@linaro.org |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Pull request for tpm-master-27052024 | expand |
Hi Tom, Don't pull this please. Miquel added his r-b tags in the meantime, I'll queue up a new one Thanks /Ilias On Mon, 27 May 2024 at 09:15, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > Hi Tom > > I know it's not early in the release and although this contains a new feature > apart from fixes, I prefer this going into -master. The added feature > is on a TPM cmd and is harmless. If you only want the fixes please let me > know and I'll send the rest in -next > > The following changes since commit a7f0154c412859323396111dd0c09dbafbc153cb: > > Prepare v2024.07-rc3 (2024-05-20 10:05:16 -0600) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-27052024 > > for you to fetch changes up to 89aa8463cdf3919ca4f04fc24ec8b154ff56d97e: > > tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend (2024-05-27 09:00:27 +0300) > > The CI https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/20873 > had no issues > > Please consider pulling > > Thanks > /Ilias > > ---------------------------------------------------------------- > Tim fixed > - An inconsistency in the reported active PCR banks. > This was only affecting EFI applications requesting the > active PCR banks from the TPM. > - Adjusted the error message when a reset GPIO for the TPM > was not found. It now prints a reasonable error message, > instead of just printing that GPIO was not found > - Enhanced the tpm command functionality. We can now define the > algorithm(sha1, 256 etc) we want to use while extending or > reading PCRs > > ---------------------------------------------------------------- > Tim Harvey (3): > tpm: display warning if using gpio reset with TPM > tpm-v2: add support for mapping algorithm names to algos > tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend > > cmd/tpm-v2.c | 49 +++++++++++++++++++-------- > drivers/tpm/tpm2_tis_spi.c | 21 +++++++----- > include/tpm-v2.h | 77 +++++++++++++++++++++++++++++++++++++++++-- > lib/efi_loader/efi_tcg2.c | 6 ++-- > lib/tpm-v2.c | 82 +++++++++++++++++++++++++++++----------------- > test/py/tests/test_tpm2.py | 2 +- > 6 files changed, 177 insertions(+), 60 deletions(-)
Hi Ilias, ilias.apalodimas@linaro.org wrote on Mon, 27 May 2024 15:01:10 +0300: > Hi Tom, > > Don't pull this please. Miquel added his r-b tags in the meantime, > I'll queue up a new one It's okay, I thought you just merged the patches in your tree, but if you already sent the PR to Tom it's okay. I'm fine with Tom pulling this version of the PR. Cheers, Miquèl
Hi Miquel, On Mon, 27 May 2024 at 15:08, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Hi Ilias, > > ilias.apalodimas@linaro.org wrote on Mon, 27 May 2024 15:01:10 +0300: > > > Hi Tom, > > > > Don't pull this please. Miquel added his r-b tags in the meantime, > > I'll queue up a new one > > It's okay, I thought you just merged the patches in your tree, Yea, that's what I tried to explain on the original thread by 'queued patches to Tom'. > but if > you already sent the PR to Tom it's okay. I'm fine with Tom pulling > this version of the PR. Thanks and apologies for pushing this early. But it contains a fix I want to land in the upcoming release. As I said this was on v5 and since no one paid attention by then, I didn't expect any other r-b tags. In any case thanks for reviewing! Regards /Ilias > > Cheers, > Miquèl
On Mon, May 27, 2024 at 09:15:04AM +0300, Ilias Apalodimas wrote: > Hi Tom > > I know it's not early in the release and although this contains a new feature > apart from fixes, I prefer this going into -master. The added feature > is on a TPM cmd and is harmless. If you only want the fixes please let me > know and I'll send the rest in -next > > The following changes since commit a7f0154c412859323396111dd0c09dbafbc153cb: > > Prepare v2024.07-rc3 (2024-05-20 10:05:16 -0600) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-27052024 > > for you to fetch changes up to 89aa8463cdf3919ca4f04fc24ec8b154ff56d97e: > > tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend (2024-05-27 09:00:27 +0300) > > The CI https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/20873 > had no issues > > Please consider pulling > > Thanks > /Ilias > Applied to u-boot/master, thanks!
Hi Tom I know it's not early in the release and although this contains a new feature apart from fixes, I prefer this going into -master. The added feature is on a TPM cmd and is harmless. If you only want the fixes please let me know and I'll send the rest in -next The following changes since commit a7f0154c412859323396111dd0c09dbafbc153cb: Prepare v2024.07-rc3 (2024-05-20 10:05:16 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-27052024 for you to fetch changes up to 89aa8463cdf3919ca4f04fc24ec8b154ff56d97e: tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend (2024-05-27 09:00:27 +0300) The CI https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/20873 had no issues Please consider pulling Thanks /Ilias ---------------------------------------------------------------- Tim fixed - An inconsistency in the reported active PCR banks. This was only affecting EFI applications requesting the active PCR banks from the TPM. - Adjusted the error message when a reset GPIO for the TPM was not found. It now prints a reasonable error message, instead of just printing that GPIO was not found - Enhanced the tpm command functionality. We can now define the algorithm(sha1, 256 etc) we want to use while extending or reading PCRs ---------------------------------------------------------------- Tim Harvey (3): tpm: display warning if using gpio reset with TPM tpm-v2: add support for mapping algorithm names to algos tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend cmd/tpm-v2.c | 49 +++++++++++++++++++-------- drivers/tpm/tpm2_tis_spi.c | 21 +++++++----- include/tpm-v2.h | 77 +++++++++++++++++++++++++++++++++++++++++-- lib/efi_loader/efi_tcg2.c | 6 ++-- lib/tpm-v2.c | 82 +++++++++++++++++++++++++++++----------------- test/py/tests/test_tpm2.py | 2 +- 6 files changed, 177 insertions(+), 60 deletions(-)