diff mbox series

ARM: imx: Increase PHY auto-negotiation timeout to 20s on MX8Menlo

Message ID 20240521093950.8810-1-marex@denx.de
State Accepted
Delegated to: Fabio Estevam
Headers show
Series ARM: imx: Increase PHY auto-negotiation timeout to 20s on MX8Menlo | expand

Commit Message

Marek Vasut May 21, 2024, 9:39 a.m. UTC
The ethernet PHY on MX8Menlo board takes a while to come out of
reset, increase the auto-negotiation timeout to prevent it from
timing out in case the ethernet is used right after the board was
reset.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Philippe Schenker <philippe.schenker@toradex.com>
Cc: Martyn Welch <martyn.welch@collabora.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: u-boot@lists.denx.de
---
 include/configs/imx8mm-mx8menlo.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Francesco Dolcini May 21, 2024, 10:12 a.m. UTC | #1
On Tue, May 21, 2024 at 11:39:38AM +0200, Marek Vasut wrote:
> The ethernet PHY on MX8Menlo board takes a while to come out of
> reset, increase the auto-negotiation timeout to prevent it from
> timing out in case the ethernet is used right after the board was
> reset.

Is this specific of MX8Menlo or something we should have on
verdin-imx8mm instead? I am not aware of any report on this issue on the
verdin, on the other hand the verdin imx8mm has normally only one
ethernet interface, and this is the one from the verdin SOM.

Francesco
Marek Vasut May 21, 2024, 10:55 a.m. UTC | #2
On 5/21/24 12:12 PM, Francesco Dolcini wrote:
> On Tue, May 21, 2024 at 11:39:38AM +0200, Marek Vasut wrote:
>> The ethernet PHY on MX8Menlo board takes a while to come out of
>> reset, increase the auto-negotiation timeout to prevent it from
>> timing out in case the ethernet is used right after the board was
>> reset.
> 
> Is this specific of MX8Menlo or something we should have on
> verdin-imx8mm instead? I am not aware of any report on this issue on the
> verdin, on the other hand the verdin imx8mm has normally only one
> ethernet interface, and this is the one from the verdin SOM.

This is specific to this particular carrier board and does not apply to 
Dahlia board or Verdin SoM.
Fabio Estevam May 24, 2024, 4:28 p.m. UTC | #3
On Tue, May 21, 2024 at 6:40 AM Marek Vasut <marex@denx.de> wrote:
>
> The ethernet PHY on MX8Menlo board takes a while to come out of
> reset, increase the auto-negotiation timeout to prevent it from
> timing out in case the ethernet is used right after the board was
> reset.
>
> Signed-off-by: Marek Vasut <marex@denx.de>

Applied, thanks.
diff mbox series

Patch

diff --git a/include/configs/imx8mm-mx8menlo.h b/include/configs/imx8mm-mx8menlo.h
index a86bd76a3c7..5cc60af91e5 100644
--- a/include/configs/imx8mm-mx8menlo.h
+++ b/include/configs/imx8mm-mx8menlo.h
@@ -8,6 +8,9 @@ 
 
 #include <configs/verdin-imx8mm.h>
 
+/* PHY needs a longer autoneg timeout */
+#define PHY_ANEG_TIMEOUT		20000
+
 /* Custom initial environment variables */
 #undef CFG_EXTRA_ENV_SETTINGS
 #define CFG_EXTRA_ENV_SETTINGS					\