diff mbox series

qcom_defconfig: enable msm8916 and msm8996

Message ID 20240507-qcom-defconfig-msm8916-v1-1-6d6914bfc00f@samcday.com
State Accepted
Delegated to: Caleb Connolly
Headers show
Series qcom_defconfig: enable msm8916 and msm8996 | expand

Commit Message

Sam Day May 7, 2024, 6:46 p.m. UTC
From: Caleb Connolly <caleb.connolly@linaro.org>

Enable the clock/pinctrl drivers for these two SoCs. Previously left out
due to only being used on the db410c and db820c respectively which both
have their own board code. We can still boot these with most features
working without that board code.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
---
I nabbed this commit from one of Caleb's work trees. Along with the
carveout patch I just sent, this gets U-Boot to successfully boot when
chained from lk2nd on msm8916 devices supported by that bootloader.

A similar plea on this patch as with the "mach-snapdragon: do carveouts
for qcs404 only" patch: if we could scrape these changes into the
2024.07 release that would be positively sublime.

Signed-off-by: Sam Day <me@samcday.com>
---
 configs/qcom_defconfig | 4 ++++
 1 file changed, 4 insertions(+)


---
base-commit: 1c40dda60f5f7e83a6d6f541cf5a57eb7e8ec43c
change-id: 20240507-qcom-defconfig-msm8916-61c8437a0b2e

Best regards,

Comments

Caleb Connolly May 8, 2024, 12:32 p.m. UTC | #1
Hi Sam,

On 07/05/2024 20:46, Sam Day wrote:
> From: Caleb Connolly <caleb.connolly@linaro.org>
> 
> Enable the clock/pinctrl drivers for these two SoCs. Previously left out
> due to only being used on the db410c and db820c respectively which both
> have their own board code. We can still boot these with most features
> working without that board code.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> I nabbed this commit from one of Caleb's work trees. Along with the
> carveout patch I just sent, this gets U-Boot to successfully boot when
> chained from lk2nd on msm8916 devices supported by that bootloader.

Thanks, it's nice to have this in, even if USB doesn't work.
> 
> A similar plea on this patch as with the "mach-snapdragon: do carveouts
> for qcs404 only" patch: if we could scrape these changes into the
> 2024.07 release that would be positively sublime.
> 
> Signed-off-by: Sam Day <me@samcday.com>
> ---
>   configs/qcom_defconfig | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
> index 80ad3b32e1..c438aeef8e 100644
> --- a/configs/qcom_defconfig
> +++ b/configs/qcom_defconfig
> @@ -37,6 +37,8 @@ CONFIG_OF_LIVE=y
>   CONFIG_OF_BOARD_SETUP=y
>   CONFIG_BUTTON_QCOM_PMIC=y
>   CONFIG_CLK=y
> +CONFIG_CLK_QCOM_APQ8016=y
> +CONFIG_CLK_QCOM_APQ8096=y
>   CONFIG_CLK_QCOM_QCM2290=y
>   CONFIG_CLK_QCOM_QCS404=y
>   CONFIG_CLK_QCOM_SDM845=y
> @@ -73,6 +75,8 @@ CONFIG_PHY_QCOM_QUSB2=y
>   CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=y
>   CONFIG_PHY_QCOM_SNPS_EUSB2=y
>   CONFIG_PINCTRL=y
> +CONFIG_PINCTRL_QCOM_APQ8016=y
> +CONFIG_PINCTRL_QCOM_APQ8096=y
>   CONFIG_PINCTRL_QCOM_QCM2290=y
>   CONFIG_PINCTRL_QCOM_QCS404=y
>   CONFIG_PINCTRL_QCOM_SDM845=y
> 
> ---
> base-commit: 1c40dda60f5f7e83a6d6f541cf5a57eb7e8ec43c
> change-id: 20240507-qcom-defconfig-msm8916-61c8437a0b2e
> 
> Best regards,
Caleb Connolly May 8, 2024, 2:14 p.m. UTC | #2
On Tue, 07 May 2024 18:46:54 +0000, Sam Day wrote:
> Enable the clock/pinctrl drivers for these two SoCs. Previously left out
> due to only being used on the db410c and db820c respectively which both
> have their own board code. We can still boot these with most features
> working without that board code.
> 
> 

Applied, thanks!

[1/1] qcom_defconfig: enable msm8916 and msm8996
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/9291868db7d9

Best regards,
diff mbox series

Patch

diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig
index 80ad3b32e1..c438aeef8e 100644
--- a/configs/qcom_defconfig
+++ b/configs/qcom_defconfig
@@ -37,6 +37,8 @@  CONFIG_OF_LIVE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_BUTTON_QCOM_PMIC=y
 CONFIG_CLK=y
+CONFIG_CLK_QCOM_APQ8016=y
+CONFIG_CLK_QCOM_APQ8096=y
 CONFIG_CLK_QCOM_QCM2290=y
 CONFIG_CLK_QCOM_QCS404=y
 CONFIG_CLK_QCOM_SDM845=y
@@ -73,6 +75,8 @@  CONFIG_PHY_QCOM_QUSB2=y
 CONFIG_PHY_QCOM_USB_SNPS_FEMTO_V2=y
 CONFIG_PHY_QCOM_SNPS_EUSB2=y
 CONFIG_PINCTRL=y
+CONFIG_PINCTRL_QCOM_APQ8016=y
+CONFIG_PINCTRL_QCOM_APQ8096=y
 CONFIG_PINCTRL_QCOM_QCM2290=y
 CONFIG_PINCTRL_QCOM_QCS404=y
 CONFIG_PINCTRL_QCOM_SDM845=y