| Message ID | 20240501235849.2224082-1-trini@konsulko.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | None | expand |
On Wed, May 01, 2024 at 05:58:49PM -0600, Tom Rini wrote: > > WARNING: This email originated from outside of GE HealthCare. Please validate the sender's email address before clicking on links or attachments as they may not be safe. > > Remove <common.h> from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini <trini@konsulko.com> Reviewed-by: Ian Ray <ian.ray@gehealthcare.com> > --- > Changes in v2: > - Remove "common.h" include as well. > > Cc: "Huan 'Kitty' Wang" <HuanWang@gehealthcare.com> > Cc: Ian Ray <ian.ray@gehealthcare.com> > Cc: Martyn Welch <martyn.welch@collabora.com> > > board/ge/b1x5v2/b1x5v2.c | 1 - > board/ge/common/ge_rtc.c | 1 - > board/ge/common/vpd_reader.h | 2 +- > board/ge/mx53ppd/mx53ppd.c | 1 - > board/ge/mx53ppd/mx53ppd_video.c | 1 - > 5 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/board/ge/b1x5v2/b1x5v2.c b/board/ge/b1x5v2/b1x5v2.c > index a2cbd1512e92..031773bc5ef3 100644 > --- a/board/ge/b1x5v2/b1x5v2.c > +++ b/board/ge/b1x5v2/b1x5v2.c > @@ -17,7 +17,6 @@ > #include <asm/io.h> > #include <asm/mach-imx/video.h> > #include <command.h> > -#include <common.h> > #include <i2c.h> > #include <input.h> > #include <ipu_pixfmt.h> > diff --git a/board/ge/common/ge_rtc.c b/board/ge/common/ge_rtc.c > index 6437afc7bd0a..5c62ecca8c89 100644 > --- a/board/ge/common/ge_rtc.c > +++ b/board/ge/common/ge_rtc.c > @@ -3,7 +3,6 @@ > * Copyright 2017 General Electric Company > */ > > -#include <common.h> > #include <env.h> > #include <dm/uclass.h> > #include <rtc.h> > diff --git a/board/ge/common/vpd_reader.h b/board/ge/common/vpd_reader.h > index 0c51dc57e902..d32c18da351c 100644 > --- a/board/ge/common/vpd_reader.h > +++ b/board/ge/common/vpd_reader.h > @@ -3,7 +3,7 @@ > * Copyright 2016 General Electric Company > */ > > -#include "common.h" > +#include <linux/types.h> > > struct vpd_cache; > > diff --git a/board/ge/mx53ppd/mx53ppd.c b/board/ge/mx53ppd/mx53ppd.c > index cc462d53da6a..9396d43f8add 100644 > --- a/board/ge/mx53ppd/mx53ppd.c > +++ b/board/ge/mx53ppd/mx53ppd.c > @@ -8,7 +8,6 @@ > * Jason Liu <r64343@freescale.com> > */ > > -#include <common.h> > #include <init.h> > #include <asm/global_data.h> > #include <asm/io.h> > diff --git a/board/ge/mx53ppd/mx53ppd_video.c b/board/ge/mx53ppd/mx53ppd_video.c > index 4e2c6ebde73c..eb4dd758b3b5 100644 > --- a/board/ge/mx53ppd/mx53ppd_video.c > +++ b/board/ge/mx53ppd/mx53ppd_video.c > @@ -8,7 +8,6 @@ > * Fabio Estevam <fabio.estevam@freescale.com> > */ > > -#include <common.h> > #include <dm.h> > #include <linux/list.h> > #include <asm/arch/iomux-mx53.h> > -- > 2.34.1 > >
diff --git a/board/ge/b1x5v2/b1x5v2.c b/board/ge/b1x5v2/b1x5v2.c index a2cbd1512e92..031773bc5ef3 100644 --- a/board/ge/b1x5v2/b1x5v2.c +++ b/board/ge/b1x5v2/b1x5v2.c @@ -17,7 +17,6 @@ #include <asm/io.h> #include <asm/mach-imx/video.h> #include <command.h> -#include <common.h> #include <i2c.h> #include <input.h> #include <ipu_pixfmt.h> diff --git a/board/ge/common/ge_rtc.c b/board/ge/common/ge_rtc.c index 6437afc7bd0a..5c62ecca8c89 100644 --- a/board/ge/common/ge_rtc.c +++ b/board/ge/common/ge_rtc.c @@ -3,7 +3,6 @@ * Copyright 2017 General Electric Company */ -#include <common.h> #include <env.h> #include <dm/uclass.h> #include <rtc.h> diff --git a/board/ge/common/vpd_reader.h b/board/ge/common/vpd_reader.h index 0c51dc57e902..d32c18da351c 100644 --- a/board/ge/common/vpd_reader.h +++ b/board/ge/common/vpd_reader.h @@ -3,7 +3,7 @@ * Copyright 2016 General Electric Company */ -#include "common.h" +#include <linux/types.h> struct vpd_cache; diff --git a/board/ge/mx53ppd/mx53ppd.c b/board/ge/mx53ppd/mx53ppd.c index cc462d53da6a..9396d43f8add 100644 --- a/board/ge/mx53ppd/mx53ppd.c +++ b/board/ge/mx53ppd/mx53ppd.c @@ -8,7 +8,6 @@ * Jason Liu <r64343@freescale.com> */ -#include <common.h> #include <init.h> #include <asm/global_data.h> #include <asm/io.h> diff --git a/board/ge/mx53ppd/mx53ppd_video.c b/board/ge/mx53ppd/mx53ppd_video.c index 4e2c6ebde73c..eb4dd758b3b5 100644 --- a/board/ge/mx53ppd/mx53ppd_video.c +++ b/board/ge/mx53ppd/mx53ppd_video.c @@ -8,7 +8,6 @@ * Fabio Estevam <fabio.estevam@freescale.com> */ -#include <common.h> #include <dm.h> #include <linux/list.h> #include <asm/arch/iomux-mx53.h>
Remove <common.h> from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini <trini@konsulko.com> --- Changes in v2: - Remove "common.h" include as well. Cc: "Huan 'Kitty' Wang" <HuanWang@gehealthcare.com> Cc: Ian Ray <ian.ray@gehealthcare.com> Cc: Martyn Welch <martyn.welch@collabora.com> board/ge/b1x5v2/b1x5v2.c | 1 - board/ge/common/ge_rtc.c | 1 - board/ge/common/vpd_reader.h | 2 +- board/ge/mx53ppd/mx53ppd.c | 1 - board/ge/mx53ppd/mx53ppd_video.c | 1 - 5 files changed, 1 insertion(+), 5 deletions(-)