diff mbox series

[17/33] arm: nexell: Remove <common.h> and add needed includes

Message ID 20240430133559.1836389-17-trini@konsulko.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [01/33] arm: mach-versatile: Remove dead code | expand

Commit Message

Tom Rini April 30, 2024, 1:35 p.m. UTC
Remove <common.h> from all mach-nexell files and when needed add missing
include files directly.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Cc: Stefan Bosch <stefan_b@posteo.net>
---
 arch/arm/mach-nexell/clock.c              | 2 +-
 arch/arm/mach-nexell/include/mach/reset.h | 2 ++
 arch/arm/mach-nexell/reset.c              | 1 -
 arch/arm/mach-nexell/tieoff.c             | 1 -
 arch/arm/mach-nexell/timer.c              | 1 -
 5 files changed, 3 insertions(+), 4 deletions(-)

Comments

Stefan Bosch May 8, 2024, 5:37 p.m. UTC | #1
On 30.04.24 15:35, Tom Rini wrote:
> Remove <common.h> from all mach-nexell files and when needed add missing
> include files directly.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Stefan Bosch <stefan_b@posteo.net>
Tested-by: Stefan Bosch <stefan_b@posteo.net>

Looks good, tested on FriendlyElec-Board NanoPC-T2.

Thanks a lot!
> ---
> Cc: Stefan Bosch <stefan_b@posteo.net>
> ---
>   arch/arm/mach-nexell/clock.c              | 2 +-
>   arch/arm/mach-nexell/include/mach/reset.h | 2 ++
>   arch/arm/mach-nexell/reset.c              | 1 -
>   arch/arm/mach-nexell/tieoff.c             | 1 -
>   arch/arm/mach-nexell/timer.c              | 1 -
>   5 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-nexell/clock.c b/arch/arm/mach-nexell/clock.c
> index 59ffa26255f5..3082f6077b73 100644
> --- a/arch/arm/mach-nexell/clock.c
> +++ b/arch/arm/mach-nexell/clock.c
> @@ -4,8 +4,8 @@
>    * Hyunseok, Jung <hsjung@nexell.co.kr>
>    */
>   
> -#include <common.h>
>   #include <command.h>
> +#include <vsprintf.h>
>   #include <linux/err.h>
>   #include <asm/io.h>
>   #include <asm/arch/nexell.h>
> diff --git a/arch/arm/mach-nexell/include/mach/reset.h b/arch/arm/mach-nexell/include/mach/reset.h
> index e1301d4e53d3..0c6a13043f91 100644
> --- a/arch/arm/mach-nexell/include/mach/reset.h
> +++ b/arch/arm/mach-nexell/include/mach/reset.h
> @@ -7,6 +7,8 @@
>   #ifndef __NEXELL_RESET__
>   #define __NEXELL_RESET__
>   
> +#include <linux/types.h>
> +
>   #define NUMBER_OF_RESET_MODULE_PIN      69
>   
>   enum rstcon {
> diff --git a/arch/arm/mach-nexell/reset.c b/arch/arm/mach-nexell/reset.c
> index 1f732a3d3732..627f568270b6 100644
> --- a/arch/arm/mach-nexell/reset.c
> +++ b/arch/arm/mach-nexell/reset.c
> @@ -8,7 +8,6 @@
>    *FIXME : Not support device tree & reset control driver.
>    *        will remove after support device tree & reset control driver.
>    */
> -#include <common.h>
>   #include <asm/io.h>
>   #include <asm/arch/nexell.h>
>   #include <asm/arch/reset.h>
> diff --git a/arch/arm/mach-nexell/tieoff.c b/arch/arm/mach-nexell/tieoff.c
> index 5a4744c296a2..51cca6744d6f 100644
> --- a/arch/arm/mach-nexell/tieoff.c
> +++ b/arch/arm/mach-nexell/tieoff.c
> @@ -4,7 +4,6 @@
>    * Youngbok, Park <park@nexell.co.kr>
>    */
>   
> -#include <common.h>
>   #include <asm/arch/nexell.h>
>   #include <asm/arch/clk.h>
>   #include <asm/arch/reset.h>
> diff --git a/arch/arm/mach-nexell/timer.c b/arch/arm/mach-nexell/timer.c
> index 3b311fd22a56..b35c7b1bb33a 100644
> --- a/arch/arm/mach-nexell/timer.c
> +++ b/arch/arm/mach-nexell/timer.c
> @@ -4,7 +4,6 @@
>    * Hyunseok, Jung <hsjung@nexell.co.kr>
>    */
>   
> -#include <common.h>
>   #include <log.h>
>   
>   #include <asm/io.h>
diff mbox series

Patch

diff --git a/arch/arm/mach-nexell/clock.c b/arch/arm/mach-nexell/clock.c
index 59ffa26255f5..3082f6077b73 100644
--- a/arch/arm/mach-nexell/clock.c
+++ b/arch/arm/mach-nexell/clock.c
@@ -4,8 +4,8 @@ 
  * Hyunseok, Jung <hsjung@nexell.co.kr>
  */
 
-#include <common.h>
 #include <command.h>
+#include <vsprintf.h>
 #include <linux/err.h>
 #include <asm/io.h>
 #include <asm/arch/nexell.h>
diff --git a/arch/arm/mach-nexell/include/mach/reset.h b/arch/arm/mach-nexell/include/mach/reset.h
index e1301d4e53d3..0c6a13043f91 100644
--- a/arch/arm/mach-nexell/include/mach/reset.h
+++ b/arch/arm/mach-nexell/include/mach/reset.h
@@ -7,6 +7,8 @@ 
 #ifndef __NEXELL_RESET__
 #define __NEXELL_RESET__
 
+#include <linux/types.h>
+
 #define NUMBER_OF_RESET_MODULE_PIN      69
 
 enum rstcon {
diff --git a/arch/arm/mach-nexell/reset.c b/arch/arm/mach-nexell/reset.c
index 1f732a3d3732..627f568270b6 100644
--- a/arch/arm/mach-nexell/reset.c
+++ b/arch/arm/mach-nexell/reset.c
@@ -8,7 +8,6 @@ 
  *FIXME : Not support device tree & reset control driver.
  *        will remove after support device tree & reset control driver.
  */
-#include <common.h>
 #include <asm/io.h>
 #include <asm/arch/nexell.h>
 #include <asm/arch/reset.h>
diff --git a/arch/arm/mach-nexell/tieoff.c b/arch/arm/mach-nexell/tieoff.c
index 5a4744c296a2..51cca6744d6f 100644
--- a/arch/arm/mach-nexell/tieoff.c
+++ b/arch/arm/mach-nexell/tieoff.c
@@ -4,7 +4,6 @@ 
  * Youngbok, Park <park@nexell.co.kr>
  */
 
-#include <common.h>
 #include <asm/arch/nexell.h>
 #include <asm/arch/clk.h>
 #include <asm/arch/reset.h>
diff --git a/arch/arm/mach-nexell/timer.c b/arch/arm/mach-nexell/timer.c
index 3b311fd22a56..b35c7b1bb33a 100644
--- a/arch/arm/mach-nexell/timer.c
+++ b/arch/arm/mach-nexell/timer.c
@@ -4,7 +4,6 @@ 
  * Hyunseok, Jung <hsjung@nexell.co.kr>
  */
 
-#include <common.h>
 #include <log.h>
 
 #include <asm/io.h>