diff mbox series

[v2,5/5] arm: apple: Do not list bootflows on boot

Message ID 20240418-apple_config-v2-5-7e5c6b9a9db3@jannau.net
State Accepted
Commit 63334ca9b593dcb378c19cc0712174dbe918e027
Delegated to: Tom Rini
Headers show
Series configs: apple: Switch to standard boot + small adjustments | expand

Commit Message

Janne Grunau via B4 Relay April 18, 2024, 7 p.m. UTC
From: Janne Grunau <j@jannau.net>

The bootflow list is only seen briefly and is probably more confusing
than helpful.

Signed-off-by: Janne Grunau <j@jannau.net>
---
 configs/apple_m1_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Neal Gompa April 19, 2024, 12:33 a.m. UTC | #1
On Thu, Apr 18, 2024 at 3:00 PM Janne Grunau via B4 Relay
<devnull+j.jannau.net@kernel.org> wrote:
>
> From: Janne Grunau <j@jannau.net>
>
> The bootflow list is only seen briefly and is probably more confusing
> than helpful.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
>  configs/apple_m1_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
> index c30aec7c55..4eac1a9e2d 100644
> --- a/configs/apple_m1_defconfig
> +++ b/configs/apple_m1_defconfig
> @@ -8,6 +8,7 @@ CONFIG_SYS_CBSIZE=256
>  CONFIG_SYS_PBSIZE=276
>  # CONFIG_DISPLAY_CPUINFO is not set
>  CONFIG_DISPLAY_BOARDINFO_LATE=y
> +CONFIG_BOOTCOMMAND="bootflow scan -b"
>  CONFIG_BOARD_LATE_INIT=y
>  CONFIG_CMD_SELECT_FONT=y
>  # CONFIG_NET is not set
>
> --
> 2.44.0
>

Reviewed-by: Neal Gompa <neal@gompa.dev>
Mark Kettenis April 19, 2024, 8:28 a.m. UTC | #2
> From: Janne Grunau via B4 Relay <devnull+j.jannau.net@kernel.org>
> Date: Thu, 18 Apr 2024 21:00:29 +0200
> 
> From: Janne Grunau <j@jannau.net>
> 
> The bootflow list is only seen briefly and is probably more confusing
> than helpful.

To be honest, I think that applies to all boards using BOOTSSTD_FILL.
Which probably means the -l should be dropped from the default
BOOTCOMMAND for BOOTSTD_FULL.  But until that happens:

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> 
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
>  configs/apple_m1_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
> index c30aec7c55..4eac1a9e2d 100644
> --- a/configs/apple_m1_defconfig
> +++ b/configs/apple_m1_defconfig
> @@ -8,6 +8,7 @@ CONFIG_SYS_CBSIZE=256
>  CONFIG_SYS_PBSIZE=276
>  # CONFIG_DISPLAY_CPUINFO is not set
>  CONFIG_DISPLAY_BOARDINFO_LATE=y
> +CONFIG_BOOTCOMMAND="bootflow scan -b"
>  CONFIG_BOARD_LATE_INIT=y
>  CONFIG_CMD_SELECT_FONT=y
>  # CONFIG_NET is not set
> 
> -- 
> 2.44.0
> 
> 
> 
>
diff mbox series

Patch

diff --git a/configs/apple_m1_defconfig b/configs/apple_m1_defconfig
index c30aec7c55..4eac1a9e2d 100644
--- a/configs/apple_m1_defconfig
+++ b/configs/apple_m1_defconfig
@@ -8,6 +8,7 @@  CONFIG_SYS_CBSIZE=256
 CONFIG_SYS_PBSIZE=276
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
+CONFIG_BOOTCOMMAND="bootflow scan -b"
 CONFIG_BOARD_LATE_INIT=y
 CONFIG_CMD_SELECT_FONT=y
 # CONFIG_NET is not set