diff mbox series

[v1] arm: dts: verdin-am62: use gpio-hog for sleep moci

Message ID 20240417083921.13367-1-eichest@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [v1] arm: dts: verdin-am62: use gpio-hog for sleep moci | expand

Commit Message

Stefan Eichenberger April 17, 2024, 8:39 a.m. UTC 
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

In Linux, we allow sleep moci to be turned off when the carrier board
supports it and the system is in suspend. In U-Boot, however, we want
the sleep moci to be always on. So we use a gpio hog and disable the
regulator. This change is necessary because we switched to upstream
device tree files with commit c07bba7a2c7e ("verdin-am62: move verdin
am62 to OF_UPSTREAM"). A recent upstream patch removes the gpio hog from
the Linux device tree, so we need to add it to the u-boot dtsi. The
following patch will remove the gpio hog from the Linux device tree:
https://lore.kernel.org/linux-devicetree/20240301084901.16656-1-eichest@gmail.com/
The U-Boot patch can be applied without it and will not break the build.

Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
 arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Tom Rini April 29, 2024, 11:04 p.m. UTC | #1 
On Wed, 17 Apr 2024 10:39:21 +0200, Stefan Eichenberger wrote:

> In Linux, we allow sleep moci to be turned off when the carrier board
> supports it and the system is in suspend. In U-Boot, however, we want
> the sleep moci to be always on. So we use a gpio hog and disable the
> regulator. This change is necessary because we switched to upstream
> device tree files with commit c07bba7a2c7e ("verdin-am62: move verdin
> am62 to OF_UPSTREAM"). A recent upstream patch removes the gpio hog from
> the Linux device tree, so we need to add it to the u-boot dtsi. The
> following patch will remove the gpio hog from the Linux device tree:
> https://lore.kernel.org/linux-devicetree/20240301084901.16656-1-eichest@gmail.com/
> The U-Boot patch can be applied without it and will not break the build.
> 
> [...]

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi b/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi
index 7fe7ae4154..9ecb305274 100644
--- a/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi
+++ b/arch/arm/dts/k3-am625-verdin-wifi-dev-u-boot.dtsi
@@ -91,6 +91,14 @@ 
 
 &main_gpio0 {
 	bootph-all;
+
+	ctrl-sleep-moci-hog {
+		bootph-all;
+		gpio-hog;
+		gpios = <31 GPIO_ACTIVE_HIGH>;
+		line-name = "CTRL_SLEEP_MOCI#";
+		output-high;
+	};
 };
 
 /* On-module I2C - PMIC_I2C */
@@ -165,10 +173,6 @@ 
 	status = "disabled";
 };
 
-&verdin_ctrl_sleep_moci {
-	bootph-all;
-};
-
 /* Verdin UART_2 */
 &wkup_uart0 {
 	bootph-all;