| Message ID | 20240410121933.152265-1-o451686892@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | 0ec4279ba32fc923374c80a3e817de263d0cc185 |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | efi_loader: using EFI_UNSUPPORTED for private authenticated variables | expand |
On 10.04.24 14:19, Weizhao Ouyang wrote: > Improve error message for UEFI SCT tests. > > Signed-off-by: Weizhao Ouyang <o451686892@gmail.com> > --- > lib/efi_loader/efi_variable.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c > index 2951dc78c7..e6c1219a11 100644 > --- a/lib/efi_loader/efi_variable.c > +++ b/lib/efi_loader/efi_variable.c > @@ -163,6 +163,7 @@ static efi_status_t efi_variable_authenticate(const u16 *variable, > break; > default: > /* TODO: support private authenticated variables */ > + ret = EFI_UNSUPPORTED; This looks more adequate than EFI_SECURITY_VIOLATION. Thanks. Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > goto err; > } >
On Wed, 10 Apr 2024 at 14:29, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > On 10.04.24 14:19, Weizhao Ouyang wrote: > > Improve error message for UEFI SCT tests. > > > > Signed-off-by: Weizhao Ouyang <o451686892@gmail.com> > > --- > > lib/efi_loader/efi_variable.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c > > index 2951dc78c7..e6c1219a11 100644 > > --- a/lib/efi_loader/efi_variable.c > > +++ b/lib/efi_loader/efi_variable.c > > @@ -163,6 +163,7 @@ static efi_status_t efi_variable_authenticate(const u16 *variable, > > break; > > default: > > /* TODO: support private authenticated variables */ > > + ret = EFI_UNSUPPORTED; > > This looks more adequate than EFI_SECURITY_VIOLATION. Thanks. > > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > > goto err; > > } > > > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c index 2951dc78c7..e6c1219a11 100644 --- a/lib/efi_loader/efi_variable.c +++ b/lib/efi_loader/efi_variable.c @@ -163,6 +163,7 @@ static efi_status_t efi_variable_authenticate(const u16 *variable, break; default: /* TODO: support private authenticated variables */ + ret = EFI_UNSUPPORTED; goto err; }
Improve error message for UEFI SCT tests. Signed-off-by: Weizhao Ouyang <o451686892@gmail.com> --- lib/efi_loader/efi_variable.c | 1 + 1 file changed, 1 insertion(+)