| Message ID | 20240327170359.2167228-1-festevam@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | mx6cuboxi: Do not print devicetree model | expand |
Hi Fabio > The mx6cuboxi_defconfig target supports several board > variants. All of these variants use the hummingboard devicetree in U-Boot. > > Currently, the devicetree model as well as the board variant name > are shown: > > U-Boot 2024.04-rc5-00003-g774ec4fda8 (Mar 27 2024 - 16:48:35 +0100) > > ... > Model: SolidRun HummingBoard2 Dual/Quad (1.5som+emmc) > Board: MX6 Cubox-i > ... > > Printing the devicetree model that is used internally by U-Boot > may confuse users. > > Unselect the CONFIG_DISPLAY_BOARDINFO option so that only the > board name is printed instead. > This is not what this patch is doing. show_board_info() is the only caller of checkboard() so we end with the following output: U-Boot 2024.04-rc5-00005-g50decee264-dirty (Mar 28 2024 - 08:09:58 +0100) CPU: Freescale i.MX6Q rev1.3 996 MHz (running at 792 MHz) CPU: Extended Commercial temperature grade (-20C to 105C) at 34C Reset cause: POR DRAM: 2 GiB Core: 84 devices, 19 uclasses, devicetree: fit WDT: Started watchdog@20bc000 with servicing every 1000ms (128s timeout) MMC: FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... *** Warning - bad CRC, using default environment Thanks & Regards, Christian
Hi Christian, On Thu, Mar 28, 2024 at 4:18 AM Christian Gmeiner <cgmeiner@igalia.com> wrote: > This is not what this patch is doing. show_board_info() is the only > caller of checkboard() > so we end with the following output: You're right. The attached patch should do what we want.
diff --git a/configs/mx6cuboxi_defconfig b/configs/mx6cuboxi_defconfig index 27ceb22599a6..e3aba715aa58 100644 --- a/configs/mx6cuboxi_defconfig +++ b/configs/mx6cuboxi_defconfig @@ -28,6 +28,7 @@ CONFIG_BOOTCOMMAND="run findfdt; run finduuid; run distro_bootcmd" CONFIG_USE_PREBOOT=y CONFIG_PREBOOT="if hdmidet; then usb start; setenv stdin serial,usbkbd; setenv stdout serial,vidconsole; setenv stderr serial,vidconsole; else setenv stdin serial; setenv stdout serial; setenv stderr serial; fi;" CONFIG_SYS_PBSIZE=532 +# CONFIG_DISPLAY_BOARDINFO is not set CONFIG_BOARD_EARLY_INIT_F=y CONFIG_SPL_SYS_MALLOC=y CONFIG_SPL_FS_EXT4=y
The mx6cuboxi_defconfig target supports several board variants. All of these variants use the hummingboard devicetree in U-Boot. Currently, the devicetree model as well as the board variant name are shown: U-Boot 2024.04-rc5-00003-g774ec4fda8 (Mar 27 2024 - 16:48:35 +0100) ... Model: SolidRun HummingBoard2 Dual/Quad (1.5som+emmc) Board: MX6 Cubox-i ... Printing the devicetree model that is used internally by U-Boot may confuse users. Unselect the CONFIG_DISPLAY_BOARDINFO option so that only the board name is printed instead. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- configs/mx6cuboxi_defconfig | 1 + 1 file changed, 1 insertion(+)