diff mbox series

[v1] board: toradex: colibri-imx8x: Remove board_gpio_init

Message ID 20240327124550.32138-1-hiagofranco@gmail.com
State Accepted
Commit a7fdca901f2cbd5cf92b32cd8e4fb6c4ab18e592
Delegated to: Fabio Estevam
Headers show
Series [v1] board: toradex: colibri-imx8x: Remove board_gpio_init | expand

Commit Message

Hiago De Franco March 27, 2024, 12:45 p.m. UTC 
From: Hiago De Franco <hiago.franco@toradex.com>

On Colibri iMX8X, the gpio initialization and usage should be handled by
the device tree, not by the colibri-imx8x.c code. Therefore, remove it.

Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
---
 board/toradex/colibri-imx8x/colibri-imx8x.c | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Fabio Estevam March 30, 2024, 7:47 p.m. UTC | #1 
On Wed, Mar 27, 2024 at 9:46 AM Hiago De Franco <hiagofranco@gmail.com> wrote:
>
> From: Hiago De Franco <hiago.franco@toradex.com>
>
> On Colibri iMX8X, the gpio initialization and usage should be handled by
> the device tree, not by the colibri-imx8x.c code. Therefore, remove it.
>
> Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>

Applied to u-boot-imx/next, thanks.
diff mbox series

Patch

diff --git a/board/toradex/colibri-imx8x/colibri-imx8x.c b/board/toradex/colibri-imx8x/colibri-imx8x.c
index 6fc8076163c6..1474297e1814 100644
--- a/board/toradex/colibri-imx8x/colibri-imx8x.c
+++ b/board/toradex/colibri-imx8x/colibri-imx8x.c
@@ -93,15 +93,6 @@  int board_early_init_f(void)
 	return 0;
 }
 
-#if IS_ENABLED(CONFIG_DM_GPIO)
-static void board_gpio_init(void)
-{
-	/* TODO */
-}
-#else
-static inline void board_gpio_init(void) {}
-#endif
-
 #if IS_ENABLED(CONFIG_FEC_MXC)
 #include <miiphy.h>
 
@@ -128,8 +119,6 @@  static void select_dt_from_module_version(void)
 
 int board_init(void)
 {
-	board_gpio_init();
-
 	if (IS_ENABLED(CONFIG_IMX_SNVS_SEC_SC_AUTO)) {
 		int ret = snvs_security_sc_init();