diff mbox series

[v2] serial: pl01x: set baudrate when probing

Message ID 20240228-b4-pl011-v2-1-92129ba2e23a@outlook.com
State Accepted
Commit 91febe80c9f2434170c6c2e866942c75372aed75
Delegated to: Tom Rini
Headers show
Series [v2] serial: pl01x: set baudrate when probing | expand

Commit Message

Yang Xiwen via B4 Relay Feb. 28, 2024, 10:57 a.m. UTC 
From: Yang Xiwen <forbidden405@outlook.com>

It is found that when DM is enabled, only generic init function is
called in .probe(). Baudrate is never honored. Add a function call
to .setbrg() when probing so that we can update the baudrate of the
serial device.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
Changes in v2:
- reverse if statement (Dan Carpenter)
- Link to v1: https://lore.kernel.org/r/20240123-b4-pl011-v1-1-fb576d0a714f@outlook.com
---
 drivers/serial/serial_pl01x.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)


---
base-commit: f7cca7ccc5117eaafcc2bde91ad1bed6fee7cfc3
change-id: 20240123-b4-pl011-ee9575ff2a38

Best regards,

Comments

Tom Rini March 7, 2024, 5:12 p.m. UTC | #1 
On Wed, Feb 28, 2024 at 06:57:52PM +0800, Yang Xiwen via B4 Relay wrote:

> From: Yang Xiwen <forbidden405@outlook.com>
> 
> It is found that when DM is enabled, only generic init function is
> called in .probe(). Baudrate is never honored. Add a function call
> to .setbrg() when probing so that we can update the baudrate of the
> serial device.
> 
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c
index 428a4d210de5..f04c21e08264 100644
--- a/drivers/serial/serial_pl01x.c
+++ b/drivers/serial/serial_pl01x.c
@@ -290,6 +290,7 @@  int pl01x_serial_probe(struct udevice *dev)
 {
 	struct pl01x_serial_plat *plat = dev_get_plat(dev);
 	struct pl01x_priv *priv = dev_get_priv(dev);
+	int ret;
 
 #if CONFIG_IS_ENABLED(OF_PLATDATA)
 	struct dtd_serial_pl01x *dtplat = &plat->dtplat;
@@ -301,10 +302,14 @@  int pl01x_serial_probe(struct udevice *dev)
 #endif
 	priv->type = plat->type;
 
-	if (!plat->skip_init)
-		return pl01x_generic_serial_init(priv->regs, priv->type);
-	else
+	if (!plat->skip_init) {
+		ret = pl01x_generic_serial_init(priv->regs, priv->type);
+		if (ret)
+			return ret;
+		return pl01x_serial_setbrg(dev, gd->baudrate);
+	} else {
 		return 0;
+	}
 }
 
 int pl01x_serial_getc(struct udevice *dev)