| Message ID | 20240207141154.1.If0aa2d32c2ffde32ed1d87ab8a088db67bc2d25c@changeid |
|---|---|
| State | Accepted |
| Commit | f226ec1e492740b900b39691517f534d60c1631c |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | stm32mp: cmd_stm32prog: add dependencies with USB_GADGET_DOWNLOAD | expand |
On Wed, Feb 7, 2024 at 2:12 PM Patrick Delaunay <patrick.delaunay@foss.st.com> wrote: > > This patch avoids compilation issue when CONFIG_USB_GADGET is deactivated > in defconfig, with undefined reference to run_usb_dnl_gadget and to > g_dnl_set_product. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig > index 8f91db4b46b9..589276282e44 100644 > --- a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig > +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig > @@ -17,6 +17,7 @@ config CMD_STM32PROG > config CMD_STM32PROG_USB > bool "support stm32prog over USB" > depends on CMD_STM32PROG > + depends on USB_GADGET_DOWNLOAD > default y > help > activate the command "stm32prog usb" for STM32MP soc family > -- > 2.25.1 > Reviewed-by: Igor Opaniuk <igor.opaniuk@foundries.io>
On 2/7/24 14:12, Patrick Delaunay wrote: > This patch avoids compilation issue when CONFIG_USB_GADGET is deactivated > in defconfig, with undefined reference to run_usb_dnl_gadget and to > g_dnl_set_product. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig > index 8f91db4b46b9..589276282e44 100644 > --- a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig > +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig > @@ -17,6 +17,7 @@ config CMD_STM32PROG > config CMD_STM32PROG_USB > bool "support stm32prog over USB" > depends on CMD_STM32PROG > + depends on USB_GADGET_DOWNLOAD > default y > help > activate the command "stm32prog usb" for STM32MP soc family Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Thanks Patrice
On 2/7/24 16:59, Igor Opaniuk wrote: > On Wed, Feb 7, 2024 at 2:12 PM Patrick Delaunay > <patrick.delaunay@foss.st.com> wrote: >> >> This patch avoids compilation issue when CONFIG_USB_GADGET is deactivated >> in defconfig, with undefined reference to run_usb_dnl_gadget and to >> g_dnl_set_product. >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> >> arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig >> index 8f91db4b46b9..589276282e44 100644 >> --- a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig >> +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig >> @@ -17,6 +17,7 @@ config CMD_STM32PROG >> config CMD_STM32PROG_USB >> bool "support stm32prog over USB" >> depends on CMD_STM32PROG >> + depends on USB_GADGET_DOWNLOAD >> default y >> help >> activate the command "stm32prog usb" for STM32MP soc family >> -- >> 2.25.1 >> > > Reviewed-by: Igor Opaniuk <igor.opaniuk@foundries.io> Applied on u-boot-stm32/master
diff --git a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig index 8f91db4b46b9..589276282e44 100644 --- a/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig +++ b/arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig @@ -17,6 +17,7 @@ config CMD_STM32PROG config CMD_STM32PROG_USB bool "support stm32prog over USB" depends on CMD_STM32PROG + depends on USB_GADGET_DOWNLOAD default y help activate the command "stm32prog usb" for STM32MP soc family
This patch avoids compilation issue when CONFIG_USB_GADGET is deactivated in defconfig, with undefined reference to run_usb_dnl_gadget and to g_dnl_set_product. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- arch/arm/mach-stm32mp/cmd_stm32prog/Kconfig | 1 + 1 file changed, 1 insertion(+)