| Message ID | 20240207083328.1673752-1-venkatesh.abbarapu@amd.com |
|---|---|
| State | Accepted |
| Commit | db23e67bbd231c02b3a1cdf900b45efda45410d4 |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | xilinx: zynqmp: Add the missing function prototype | expand |
On 2/7/24 09:33, Venkatesh Yadav Abbarapu wrote: > Add missing prototype to fix the below sparse warning > warning: no previous prototype for 'spl_spi_get_uboot_offs' > [-Wmissing-prototypes] > > Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> > --- > board/xilinx/zynqmp/zynqmp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c > index 9f50090720..ba49eb7be2 100644 > --- a/board/xilinx/zynqmp/zynqmp.c > +++ b/board/xilinx/zynqmp/zynqmp.c > @@ -18,6 +18,7 @@ > #include <ahci.h> > #include <scsi.h> > #include <soc.h> > +#include <spl.h> > #include <malloc.h> > #include <memalign.h> > #include <wdt.h> good. Please send it to upstream. M
On 2/7/24 12:30, Michal Simek wrote: > > > On 2/7/24 09:33, Venkatesh Yadav Abbarapu wrote: >> Add missing prototype to fix the below sparse warning >> warning: no previous prototype for 'spl_spi_get_uboot_offs' >> [-Wmissing-prototypes] >> >> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> >> --- >> board/xilinx/zynqmp/zynqmp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c >> index 9f50090720..ba49eb7be2 100644 >> --- a/board/xilinx/zynqmp/zynqmp.c >> +++ b/board/xilinx/zynqmp/zynqmp.c >> @@ -18,6 +18,7 @@ >> #include <ahci.h> >> #include <scsi.h> >> #include <soc.h> >> +#include <spl.h> >> #include <malloc.h> >> #include <memalign.h> >> #include <wdt.h> > > > good. Please send it to upstream. :-) this is already upstreamed. Applied with also Fixes: 2c8a09219cdb ("arm64: zynqmp: Add multiboot support for SPL/SPI offset calculation") Thanks, Michal
diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c index 9f50090720..ba49eb7be2 100644 --- a/board/xilinx/zynqmp/zynqmp.c +++ b/board/xilinx/zynqmp/zynqmp.c @@ -18,6 +18,7 @@ #include <ahci.h> #include <scsi.h> #include <soc.h> +#include <spl.h> #include <malloc.h> #include <memalign.h> #include <wdt.h>
Add missing prototype to fix the below sparse warning warning: no previous prototype for 'spl_spi_get_uboot_offs' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> --- board/xilinx/zynqmp/zynqmp.c | 1 + 1 file changed, 1 insertion(+)