diff mbox series

[v2,3/3] mx6sabresd: Remove board_phy_config()

Message ID 20240202160405.4126192-3-festevam@gmail.com
State Accepted
Commit 450af2495e4cfb085b9850653ca498479c4bdb18
Delegated to: Fabio Estevam
Headers show
Series [v2,1/3] mx6sabresd: Fix U-Boot corruption after saving the environment | expand

Commit Message

Fabio Estevam Feb. 2, 2024, 4:04 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

With Ethernet DM in place, there is no longer the need for having
the board_phy_config() anymore.
    
Remove it.

Confirmed that TFTP transfer still works fine without board_phy_config().

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Newly introduced.

 board/freescale/mx6sabresd/mx6sabresd.c | 34 -------------------------
 1 file changed, 34 deletions(-)

Comments

Igor Opaniuk Feb. 2, 2024, 8:14 p.m. UTC | #1 
Hello Fabio,

On Fri, Feb 2, 2024 at 5:04 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> With Ethernet DM in place, there is no longer the need for having
> the board_phy_config() anymore.
>
> Remove it.
>
> Confirmed that TFTP transfer still works fine without board_phy_config().
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Newly introduced.
>
>  board/freescale/mx6sabresd/mx6sabresd.c | 34 -------------------------
>  1 file changed, 34 deletions(-)
>
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index b558a596dff8..bb066a5d36c3 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -7,7 +7,6 @@
>
>  #include <image.h>
>  #include <init.h>
> -#include <net.h>
>  #include <asm/arch/clock.h>
>  #include <asm/arch/imx-regs.h>
>  #include <asm/arch/iomux.h>
> @@ -254,39 +253,6 @@ int board_mmc_init(struct bd_info *bis)
>  }
>  #endif
>
> -static int ar8031_phy_fixup(struct phy_device *phydev)
> -{
> -       unsigned short val;
> -
> -       /* To enable AR8031 ouput a 125MHz clk from CLK_25M */
> -       phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
> -       phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
> -       phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
> -
> -       val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
> -       val &= 0xffe3;
> -       val |= 0x18;
> -       phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
> -
> -       /* introduce tx clock delay */
> -       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
> -       val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
> -       val |= 0x0100;
> -       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
> -
> -       return 0;
> -}
> -
> -int board_phy_config(struct phy_device *phydev)
> -{
> -       ar8031_phy_fixup(phydev);
> -
> -       if (phydev->drv->config)
> -               phydev->drv->config(phydev);
> -
> -       return 0;
> -}
> -
>  #if defined(CONFIG_VIDEO_IPUV3)
>  static void disable_lvds(struct display_info_t const *dev)
>  {
> --
> 2.34.1
>

Reviewed-by: Igor Opaniuk <igor.opaniuk@foundries.io>
diff mbox series

Patch

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index b558a596dff8..bb066a5d36c3 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -7,7 +7,6 @@ 
 
 #include <image.h>
 #include <init.h>
-#include <net.h>
 #include <asm/arch/clock.h>
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/iomux.h>
@@ -254,39 +253,6 @@  int board_mmc_init(struct bd_info *bis)
 }
 #endif
 
-static int ar8031_phy_fixup(struct phy_device *phydev)
-{
-	unsigned short val;
-
-	/* To enable AR8031 ouput a 125MHz clk from CLK_25M */
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
-
-	val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
-	val &= 0xffe3;
-	val |= 0x18;
-	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
-
-	/* introduce tx clock delay */
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
-	val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
-	val |= 0x0100;
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
-
-	return 0;
-}
-
-int board_phy_config(struct phy_device *phydev)
-{
-	ar8031_phy_fixup(phydev);
-
-	if (phydev->drv->config)
-		phydev->drv->config(phydev);
-
-	return 0;
-}
-
 #if defined(CONFIG_VIDEO_IPUV3)
 static void disable_lvds(struct display_info_t const *dev)
 {