diff mbox series

[2/3] smbios: do not determine maximum structure size

Message ID 20240201002022.11258-3-heinrich.schuchardt@canonical.com
State Accepted, archived
Commit e494258deddcae4a6805abfbb643b2fdc8ac3736
Delegated to: Tom Rini
Headers show
Series smbios: correct handling of table size | expand

Commit Message

Heinrich Schuchardt Feb. 1, 2024, 12:20 a.m. UTC 
Only the SMBIOS 2.1 entry point has a field for the maximum structure size.
As we have switched to an SMBIOS 3 entry point remove the superfluous
calculation.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 lib/smbios.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/lib/smbios.c b/lib/smbios.c
index cd750cc218..327f78c8b0 100644
--- a/lib/smbios.c
+++ b/lib/smbios.c
@@ -566,7 +566,6 @@  ulong write_smbios_table(ulong addr)
 	struct smbios_ctx ctx;
 	ulong tables;
 	int len = 0;
-	int max_struct_size = 0;
 	int handle = 0;
 	int i;
 
@@ -588,7 +587,6 @@  ulong write_smbios_table(ulong addr)
 	/* populate minimum required tables */
 	for (i = 0; i < ARRAY_SIZE(smbios_write_funcs); i++) {
 		const struct smbios_write_method *method;
-		int tmp;
 
 		method = &smbios_write_funcs[i];
 		ctx.subnode_name = NULL;
@@ -598,10 +596,7 @@  ulong write_smbios_table(ulong addr)
 				ctx.node = ofnode_find_subnode(parent_node,
 							       method->subnode_name);
 		}
-		tmp = method->write((ulong *)&addr, handle++, &ctx);
-
-		max_struct_size = max(max_struct_size, tmp);
-		len += tmp;
+		len += method->write((ulong *)&addr, handle++, &ctx);
 	}
 
 	/*