| Message ID | 20240127134850.582763-1-aurelien@aurel32.net |
|---|---|
| State | Accepted |
| Commit | 386db9a26b454d33b688fbe811289daaa22466af |
| Delegated to: | Andes |
| Headers | show |
| Series | configs: visionfive2: Disable ENV_IS_NOWHERE | expand |
LGTM. Maintainers, please also apply this patch to 2024.04 branch when accepting it. Best regards, Shengyu > The VisionFive 2 board supports saving the u-boot environment settings > are saved to on-board SPI flash. However the defconfig enables both > ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command > to work. Fix that by disabling ENV_IS_NOWHERE. > > Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support") > > Reported-by: E Shattow <lucent@gmail.com> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > --- > configs/starfive_visionfive2_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig > index 1b7d57bac7..c68f3c2def 100644 > --- a/configs/starfive_visionfive2_defconfig > +++ b/configs/starfive_visionfive2_defconfig > @@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y > CONFIG_CMD_BOOTSTAGE=y > CONFIG_OF_BOARD=y > CONFIG_ENV_OVERWRITE=y > -CONFIG_ENV_IS_NOWHERE=y > CONFIG_ENV_IS_IN_SPI_FLASH=y > CONFIG_ENV_SECT_SIZE_AUTO=y > CONFIG_SYS_RELOC_GD_ENV_ADDR=y
On Sat, Jan 27, 2024 at 02:48:45PM +0100, Aurelien Jarno wrote: > The VisionFive 2 board supports saving the u-boot environment settings > are saved to on-board SPI flash. However the defconfig enables both > ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command > to work. Fix that by disabling ENV_IS_NOWHERE. > > Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support") > > Reported-by: E Shattow <lucent@gmail.com> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> > --- > configs/starfive_visionfive2_defconfig | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index 1b7d57bac7..c68f3c2def 100644 --- a/configs/starfive_visionfive2_defconfig +++ b/configs/starfive_visionfive2_defconfig @@ -77,7 +77,6 @@ CONFIG_CMD_TFTPPUT=y CONFIG_CMD_BOOTSTAGE=y CONFIG_OF_BOARD=y CONFIG_ENV_OVERWRITE=y -CONFIG_ENV_IS_NOWHERE=y CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_ENV_SECT_SIZE_AUTO=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y
The VisionFive 2 board supports saving the u-boot environment settings are saved to on-board SPI flash. However the defconfig enables both ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command to work. Fix that by disabling ENV_IS_NOWHERE. Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support") Reported-by: E Shattow <lucent@gmail.com> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net> --- configs/starfive_visionfive2_defconfig | 1 - 1 file changed, 1 deletion(-)