diff mbox series

[v3,14/17] ARM: dts: rk3328: Enable VOP for bootph-all

Message ID 20240117075154.58747-15-jagan@amarulasolutions.com
State Accepted
Delegated to: Anatolij Gustschin
Headers show
Series video: dw_hdmi: Support Vendor PHY | expand

Commit Message

Jagan Teki Jan. 17, 2024, 7:51 a.m. UTC
Model: Firefly roc-rk3328-cc
DRAM: 1 GiB (effective 1022 MiB)
Video device 'vop@ff370000' cannot allocate frame buffer memory -ensure the device is set up before relocation
Error binding driver 'rockchip_rk3328_vop': -28
Some drivers failed to bind
initcall sequence 000000003ffcd5e8 failed at call 000000000021a5c4 (err=-28)
 ### ERROR ### Please RESET the board ###

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v3, v2:
- none

 arch/arm/dts/rk3328-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jonas Karlman Feb. 19, 2024, 5:21 p.m. UTC | #1
Hi Jagan,

On 2024-01-17 08:51, Jagan Teki wrote:
> Model: Firefly roc-rk3328-cc
> DRAM: 1 GiB (effective 1022 MiB)
> Video device 'vop@ff370000' cannot allocate frame buffer memory -ensure the device is set up before relocation
> Error binding driver 'rockchip_rk3328_vop': -28
> Some drivers failed to bind
> initcall sequence 000000003ffcd5e8 failed at call 000000000021a5c4 (err=-28)
>  ### ERROR ### Please RESET the board ###
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v3, v2:
> - none
> 
>  arch/arm/dts/rk3328-u-boot.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi
> index a9f2536de2..5258fec566 100644
> --- a/arch/arm/dts/rk3328-u-boot.dtsi
> +++ b/arch/arm/dts/rk3328-u-boot.dtsi
> @@ -68,3 +68,7 @@
>  &spi0 {
>  	bootph-all;
>  };
> +
> +&vop {
> +	bootph-all;

bootph-some-ram is better, TPL or SPL does not need or use the vop node.

I am working on a cleanup series for rk3399 and that series will include
a change from bootph-all to bootph-some-ram of vop nodes on rk3399.

Regards,
Jonas

> +};
Jagan Teki Feb. 19, 2024, 6:32 p.m. UTC | #2
Hi Jonas,

On Mon, Feb 19, 2024 at 10:51 PM Jonas Karlman <jonas@kwiboo.se> wrote:
>
> Hi Jagan,
>
> On 2024-01-17 08:51, Jagan Teki wrote:
> > Model: Firefly roc-rk3328-cc
> > DRAM: 1 GiB (effective 1022 MiB)
> > Video device 'vop@ff370000' cannot allocate frame buffer memory -ensure the device is set up before relocation
> > Error binding driver 'rockchip_rk3328_vop': -28
> > Some drivers failed to bind
> > initcall sequence 000000003ffcd5e8 failed at call 000000000021a5c4 (err=-28)
> >  ### ERROR ### Please RESET the board ###
> >
> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > ---
> > Changes for v3, v2:
> > - none
> >
> >  arch/arm/dts/rk3328-u-boot.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi
> > index a9f2536de2..5258fec566 100644
> > --- a/arch/arm/dts/rk3328-u-boot.dtsi
> > +++ b/arch/arm/dts/rk3328-u-boot.dtsi
> > @@ -68,3 +68,7 @@
> >  &spi0 {
> >       bootph-all;
> >  };
> > +
> > +&vop {
> > +     bootph-all;
>
> bootph-some-ram is better, TPL or SPL does not need or use the vop node.
>
> I am working on a cleanup series for rk3399 and that series will include
> a change from bootph-all to bootph-some-ram of vop nodes on rk3399.

Sure, we can even update the same later as these were in the ML from
months ago. I will mark them as well.

Jagan.
diff mbox series

Patch

diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi
index a9f2536de2..5258fec566 100644
--- a/arch/arm/dts/rk3328-u-boot.dtsi
+++ b/arch/arm/dts/rk3328-u-boot.dtsi
@@ -68,3 +68,7 @@ 
 &spi0 {
 	bootph-all;
 };
+
+&vop {
+	bootph-all;
+};