diff mbox series

[07/13] x86: zboot: Drop intermediate zboot_setup() function

Message ID 20231204002944.897949-8-sjg@chromium.org
State Accepted
Commit cb19931ee56f52779d6dba97a0934afe97167840
Delegated to: Tom Rini
Headers show
Series Complete decoupling of zboot logic from commands | expand

Commit Message

Simon Glass Dec. 4, 2023, 12:29 a.m. UTC 
Move error checking into the caller so that do_zboot_setup() can call
zboot_setup() directly.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 cmd/x86/zboot.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/cmd/x86/zboot.c b/cmd/x86/zboot.c
index d39ab6a9698f..f392b6b3e493 100644
--- a/cmd/x86/zboot.c
+++ b/cmd/x86/zboot.c
@@ -74,11 +74,10 @@  static int do_zboot_load(struct cmd_tbl *cmdtp, int flag, int argc,
 	return 0;
 }
 
-static int _zboot_setup(void)
+static int do_zboot_setup(struct cmd_tbl *cmdtp, int flag, int argc,
+			  char *const argv[])
 {
-	struct boot_params *base_ptr = state.base_ptr;
-
-	if (!base_ptr) {
+	if (!state.base_ptr) {
 		printf("base is not set: use 'zboot load' first\n");
 		return CMD_RET_FAILURE;
 	}
@@ -87,13 +86,10 @@  static int _zboot_setup(void)
 		return CMD_RET_FAILURE;
 	}
 
-	return 0;
-}
+	if (zboot_setup())
+		return CMD_RET_FAILURE;
 
-static int do_zboot_setup(struct cmd_tbl *cmdtp, int flag, int argc,
-			  char *const argv[])
-{
-	return _zboot_setup();
+	return 0;
 }
 
 static void zboot_info(void)