diff mbox series

starfive: visionfive2: add device tree overlay support

Message ID 20231120023549.13902-1-inindev@gmail.com
State Accepted
Commit 94533cd9c15a60b74420e53a725fab54d38dd555
Delegated to: Andes
Headers show
Series starfive: visionfive2: add device tree overlay support | expand

Commit Message

John Clark Nov. 20, 2023, 2:35 a.m. UTC
device tree overlay support requires fdtoverlay_addr_r to be set

before
~~~~~~
Invalid fdtoverlay_addr_r for loading overlays

after
~~~~~
Retrieving file: /boot/overlay/rtc-ds3231.dtbo

Signed-off-by: John Clark <inindev@gmail.com>
---

 include/configs/starfive-visionfive2.h | 1 +
 1 file changed, 1 insertion(+)

Comments

John Clark Nov. 20, 2023, 10:32 a.m. UTC | #1
> device tree overlay support requires fdtoverlay_addr_r to be set
>
> before
> ~~~~~~
> Invalid fdtoverlay_addr_r for loading overlays
>
> after
> ~~~~~
> Retrieving file: /boot/overlay/rtc-ds3231.dtbo
>
> Signed-off-by: John Clark<inindev@gmail.com>
> ---
>
>   include/configs/starfive-visionfive2.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/starfive-visionfive2.h b/include/configs/starfive-visionfive2.h
> index ff43113f24..29c74470c7 100644
> --- a/include/configs/starfive-visionfive2.h
> +++ b/include/configs/starfive-visionfive2.h
> @@ -40,6 +40,7 @@
>   	"kernel_comp_addr_r=0x88000000\0" \
>   	"kernel_comp_size=0x4000000\0" \
>   	"fdt_addr_r=0x46000000\0" \
> +	"fdtoverlay_addr_r=0x45800000\0" \
>   	"scriptaddr=0x43900000\0" \
>   	"pxefile_addr_r=0x45900000\0" \
>   	"ramdisk_addr_r=0x46100000\0" \

Additional detail as to the selection of 0x45800000 as the location to 
place fdtoverlay_addr_r:

"kernel_comp_addr_r=0x88000000\0" \     "ramdisk_addr_r=0x46100000\0" 
\   0x41F00000         "fdt_addr_r=0x46000000\0" \     0x100000     
"pxefile_addr_r=0x45900000\0" \     0x700000 
  "fdtoverlay_addr_r=0x45800000\0" \     0x100000         
"scriptaddr=0x43900000\0" \    0x1F00000      
"kernel_addr_r=0x40200000\0" \    0x3700000    
"kernel_comp_size=0x4000000\0" \
Leo Liang Dec. 4, 2023, 12:53 p.m. UTC | #2
On Mon, Nov 20, 2023 at 02:35:31AM +0000, John Clark wrote:
> device tree overlay support requires fdtoverlay_addr_r to be set
> 
> before
> ~~~~~~
> Invalid fdtoverlay_addr_r for loading overlays
> 
> after
> ~~~~~
> Retrieving file: /boot/overlay/rtc-ds3231.dtbo
> 
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
> 
>  include/configs/starfive-visionfive2.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
diff mbox series

Patch

diff --git a/include/configs/starfive-visionfive2.h b/include/configs/starfive-visionfive2.h
index ff43113f24..29c74470c7 100644
--- a/include/configs/starfive-visionfive2.h
+++ b/include/configs/starfive-visionfive2.h
@@ -40,6 +40,7 @@ 
 	"kernel_comp_addr_r=0x88000000\0" \
 	"kernel_comp_size=0x4000000\0" \
 	"fdt_addr_r=0x46000000\0" \
+	"fdtoverlay_addr_r=0x45800000\0" \
 	"scriptaddr=0x43900000\0" \
 	"pxefile_addr_r=0x45900000\0" \
 	"ramdisk_addr_r=0x46100000\0" \