| Message ID | 20231104072150.3339-7-nm@ti.com |
|---|---|
| State | Accepted |
| Commit | 97bf082c9f8ff106cf238b1a3c4190944c3e920f |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | board: ti: j721e: cleanup | expand |
On 11/4/23 2:21 AM, Nishanth Menon wrote: > J7200 shares quite a few characteristics with J721E. However a few sets > are different. Introduce a Kconfig to differentiate the two to allow for > new boards to be introduced in a seamless manner. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > arch/arm/mach-k3/Kconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig > index 9168bf842dca..57e2dd966eb8 100644 > --- a/arch/arm/mach-k3/Kconfig > +++ b/arch/arm/mach-k3/Kconfig > @@ -24,6 +24,11 @@ config SOC_K3_AM62A7 > > endchoice > > +if SOC_K3_J721E > +config SOC_K3_J721E_J7200 I'm sure you know how messy this is :( We wanted to treat J7200 as a proper subset device of J721e but we also know that didn't happen. These two SoCs ended up more different than expected and although still very similar I believe continuing to try to support both under one name is not the right solution. We will split out J7200 from J721e in TF-A[0] for similar reasons, might be time to do the same in u-boot. Andrew [0] https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23970 > + bool "TI's K3 based J7200 SoC variant Family Support" > +endif > + > config SYS_SOC > default "k3" >
On 10:45-20231106, Andrew Davis wrote: > On 11/4/23 2:21 AM, Nishanth Menon wrote: > > J7200 shares quite a few characteristics with J721E. However a few sets > > are different. Introduce a Kconfig to differentiate the two to allow for > > new boards to be introduced in a seamless manner. > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > --- > > arch/arm/mach-k3/Kconfig | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig > > index 9168bf842dca..57e2dd966eb8 100644 > > --- a/arch/arm/mach-k3/Kconfig > > +++ b/arch/arm/mach-k3/Kconfig > > @@ -24,6 +24,11 @@ config SOC_K3_AM62A7 > > endchoice > > +if SOC_K3_J721E > > +config SOC_K3_J721E_J7200 > > I'm sure you know how messy this is :( > > We wanted to treat J7200 as a proper subset device of J721e but we > also know that didn't happen. These two SoCs ended up more different > than expected and although still very similar I believe continuing > to try to support both under one name is not the right solution. > > We will split out J7200 from J721e in TF-A[0] for similar reasons, > might be time to do the same in u-boot. Yes, I am aware. A follow on series to cleanup J7200 will be appreciated.
diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 9168bf842dca..57e2dd966eb8 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig @@ -24,6 +24,11 @@ config SOC_K3_AM62A7 endchoice +if SOC_K3_J721E +config SOC_K3_J721E_J7200 + bool "TI's K3 based J7200 SoC variant Family Support" +endif + config SYS_SOC default "k3"
J7200 shares quite a few characteristics with J721E. However a few sets are different. Introduce a Kconfig to differentiate the two to allow for new boards to be introduced in a seamless manner. Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm/mach-k3/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)