diff mbox series

net: eth-uclass: Improve error message when MAC is not found

Message ID 20231019215720.1839630-1-festevam@gmail.com
State Superseded
Headers show
Series net: eth-uclass: Improve error message when MAC is not found | expand

Commit Message

Fabio Estevam Oct. 19, 2023, 9:57 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

While bringinp up a new board without the MAC fuses programmed,
the following error message was observed:

Error: ethernet@30bf0000 address not set.

Improve the error message to make it clearer the reason of
the failure.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 net/eth-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lothar Waßmann Oct. 20, 2023, 6:57 a.m. UTC | #1
Hi,

On Thu, 19 Oct 2023 18:57:20 -0300 Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> While bringinp up a new board without the MAC fuses programmed,
> the following error message was observed:
> 
> Error: ethernet@30bf0000 address not set.
> 
> Improve the error message to make it clearer the reason of
> the failure.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  net/eth-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/eth-uclass.c b/net/eth-uclass.c
> index 4311f3fe6e89..1f0985ec52ca 100644
> --- a/net/eth-uclass.c
> +++ b/net/eth-uclass.c
> @@ -594,7 +594,7 @@ static int eth_post_probe(struct udevice *dev)
>  		eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
>  					      pdata->enetaddr);
>  #else
> -		printf("\nError: %s address not set.\n",
> +		printf("\nError: %s a valid MAC address was not found.\n",
>
printf("\nError: %s No valid MAC address found.\n",


Lothar Waßmann
diff mbox series

Patch

diff --git a/net/eth-uclass.c b/net/eth-uclass.c
index 4311f3fe6e89..1f0985ec52ca 100644
--- a/net/eth-uclass.c
+++ b/net/eth-uclass.c
@@ -594,7 +594,7 @@  static int eth_post_probe(struct udevice *dev)
 		eth_env_set_enetaddr_by_index("eth", dev_seq(dev),
 					      pdata->enetaddr);
 #else
-		printf("\nError: %s address not set.\n",
+		printf("\nError: %s a valid MAC address was not found.\n",
 		       dev->name);
 		return -EINVAL;
 #endif