| Message ID | 20231018185530.1272005-1-festevam@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [v4] imx8mp-dhcom-pdk3-overlay-rev100: Pass #address-cells/size-cells | expand |
On 10/18/23 20:55, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Pass #address-cells/size-cells in the mdio node to avoid the following > DTC warning: > > DTCO arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dtbo > Warning (reg_format): /fragment@0/__overlay__:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #address-cells value > Warning (avoid_default_addr_size): /fragment@0/__overlay__: Relying on default #size-cells value > > Also change the Ethernet PHY address to 5, as per Marek's feedback. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v3: > - Change the Ethernet PHY address to 5 for good :-). (Marek) > > arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts > index f27e6429abe4..bad015536166 100644 > --- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts > +++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts > @@ -5,6 +5,13 @@ > /dts-v1/; > /plugin/; > > -ðphy0g { > - reg = <7>; > +&eqos { > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-phy@5 { > + reg = <5>; The reg should be 'reg = <7>' ;-) It's just the node name which should be 'ethernet-phy@5'. (Yes, I know, it is not consistent, that's because the DTO cannot "rename" the node itself easily).
diff --git a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts index f27e6429abe4..bad015536166 100644 --- a/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts +++ b/arch/arm/dts/imx8mp-dhcom-pdk3-overlay-rev100.dts @@ -5,6 +5,13 @@ /dts-v1/; /plugin/; -ðphy0g { - reg = <7>; +&eqos { + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethernet-phy@5 { + reg = <5>; + }; + }; };