| Message ID | 20231005030202.2764-1-venkatesh.abbarapu@amd.com |
|---|---|
| State | Superseded |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | net: phy: xilinx_phy: Get rid of using property xlnx, phy-type | expand |
On 10/5/23 05:02, Venkatesh Yadav Abbarapu wrote: > As the xlnx,phy-type device tree property is deprecated and phy-mode > is being used, so removing the code references of xlnx,phy-type. > > Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> > --- > drivers/net/phy/xilinx_phy.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/phy/xilinx_phy.c b/drivers/net/phy/xilinx_phy.c > index 1df639d6f4..50f1611ad5 100644 > --- a/drivers/net/phy/xilinx_phy.c > +++ b/drivers/net/phy/xilinx_phy.c > @@ -107,10 +107,6 @@ static int xilinxphy_of_init(struct phy_device *phydev) > if (!ofnode_valid(node)) > return -EINVAL; > > - phytype = ofnode_read_u32_default(node, "xlnx,phy-type", -1); > - if (phytype == XAE_PHY_TYPE_1000BASE_X) > - phydev->flags |= XAE_PHY_TYPE_1000BASE_X; > - > return 0; > } > Applied. M
On 10/9/23 12:15, Michal Simek wrote: > > > On 10/5/23 05:02, Venkatesh Yadav Abbarapu wrote: >> As the xlnx,phy-type device tree property is deprecated and phy-mode >> is being used, so removing the code references of xlnx,phy-type. >> >> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> >> --- >> drivers/net/phy/xilinx_phy.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/net/phy/xilinx_phy.c b/drivers/net/phy/xilinx_phy.c >> index 1df639d6f4..50f1611ad5 100644 >> --- a/drivers/net/phy/xilinx_phy.c >> +++ b/drivers/net/phy/xilinx_phy.c >> @@ -107,10 +107,6 @@ static int xilinxphy_of_init(struct phy_device *phydev) >> if (!ofnode_valid(node)) >> return -EINVAL; >> - phytype = ofnode_read_u32_default(node, "xlnx,phy-type", -1); >> - if (phytype == XAE_PHY_TYPE_1000BASE_X) >> - phydev->flags |= XAE_PHY_TYPE_1000BASE_X; >> - >> return 0; >> } > > Applied. > M Actually no. I will remove this patch from my queue. You also need to remove phytype variable. That's why please send v2 on this. M
diff --git a/drivers/net/phy/xilinx_phy.c b/drivers/net/phy/xilinx_phy.c index 1df639d6f4..50f1611ad5 100644 --- a/drivers/net/phy/xilinx_phy.c +++ b/drivers/net/phy/xilinx_phy.c @@ -107,10 +107,6 @@ static int xilinxphy_of_init(struct phy_device *phydev) if (!ofnode_valid(node)) return -EINVAL; - phytype = ofnode_read_u32_default(node, "xlnx,phy-type", -1); - if (phytype == XAE_PHY_TYPE_1000BASE_X) - phydev->flags |= XAE_PHY_TYPE_1000BASE_X; - return 0; }
As the xlnx,phy-type device tree property is deprecated and phy-mode is being used, so removing the code references of xlnx,phy-type. Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com> --- drivers/net/phy/xilinx_phy.c | 4 ---- 1 file changed, 4 deletions(-)