| Message ID | 20230824031101.3460411-3-nm@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | board: ti: Add support for BeaglePlay | expand |
Hi Nishanth, On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote: > Drop unused macro. This was meant for a second region of DDR which we > do not need for AM62x evm configurations. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > New patch (part of bootstd transition) > > include/configs/am62x_evm.h | 3 --- > 1 file changed, 3 deletions(-) What about include/configs/verdin-am62.h ? It seems that that board, which is am62x based, also has the un-needed include. Since i'm not 100% sure, I have added Marcel (who posted the verdin am62 support) here. > > diff --git a/include/configs/am62x_evm.h b/include/configs/am62x_evm.h > index 44180dc7687b..379e0c13a395 100644 > --- a/include/configs/am62x_evm.h > +++ b/include/configs/am62x_evm.h > @@ -12,9 +12,6 @@ > #include <config_distro_bootcmd.h> > #include <env/ti/mmc.h> > > -/* DDR Configuration */ > -#define CFG_SYS_SDRAM_BASE1 0x880000000 > - > /* Now for the remaining common defines */ > #include <configs/ti_armv7_common.h> > > -- > 2.40.0
On 10:13-20230824, Mattijs Korpershoek wrote: > Hi Nishanth, > > On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote: > > > Drop unused macro. This was meant for a second region of DDR which we > > do not need for AM62x evm configurations. > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > --- > > New patch (part of bootstd transition) > > > > include/configs/am62x_evm.h | 3 --- > > 1 file changed, 3 deletions(-) > > What about include/configs/verdin-am62.h ? > > It seems that that board, which is am62x based, also has the un-needed > include. > > Since i'm not 100% sure, I have added Marcel (who posted the verdin am62 > support) here. Toradex team, Can you handle that cleanup? I stayed focussed on am62x_evm side of things. > > > > > diff --git a/include/configs/am62x_evm.h b/include/configs/am62x_evm.h > > index 44180dc7687b..379e0c13a395 100644 > > --- a/include/configs/am62x_evm.h > > +++ b/include/configs/am62x_evm.h > > @@ -12,9 +12,6 @@ > > #include <config_distro_bootcmd.h> > > #include <env/ti/mmc.h> > > > > -/* DDR Configuration */ > > -#define CFG_SYS_SDRAM_BASE1 0x880000000 > > - > > /* Now for the remaining common defines */ > > #include <configs/ti_armv7_common.h> > > > > -- > > 2.40.0
On Thu, 2023-08-24 at 07:05 -0500, Nishanth Menon wrote: > On 10:13-20230824, Mattijs Korpershoek wrote: > > Hi Nishanth, > > > > On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote: > > > > > Drop unused macro. This was meant for a second region of DDR which we > > > do not need for AM62x evm configurations. > > > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > --- > > > New patch (part of bootstd transition) > > > > > > include/configs/am62x_evm.h | 3 --- > > > 1 file changed, 3 deletions(-) > > > > What about include/configs/verdin-am62.h ? > > > > It seems that that board, which is am62x based, also has the un-needed > > include. > > > > Since i'm not 100% sure, I have added Marcel (who posted the verdin am62 > > support) here. > > Toradex team, Can you handle that cleanup? I stayed focussed on am62x_evm side > of things. Yes, of course. > > > diff --git a/include/configs/am62x_evm.h b/include/configs/am62x_evm.h > > > index 44180dc7687b..379e0c13a395 100644 > > > --- a/include/configs/am62x_evm.h > > > +++ b/include/configs/am62x_evm.h > > > @@ -12,9 +12,6 @@ > > > #include <config_distro_bootcmd.h> > > > #include <env/ti/mmc.h> > > > > > > -/* DDR Configuration */ > > > -#define CFG_SYS_SDRAM_BASE1 0x880000000 > > > - > > > /* Now for the remaining common defines */ > > > #include <configs/ti_armv7_common.h> > > > > > > -- > > > 2.40.0
On Thu, Aug 24, 2023 at 01:02:21PM +0000, Marcel Ziswiler wrote: > On Thu, 2023-08-24 at 07:05 -0500, Nishanth Menon wrote: > > On 10:13-20230824, Mattijs Korpershoek wrote: > > > Hi Nishanth, > > > > > > On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote: > > > > > > > Drop unused macro. This was meant for a second region of DDR which we > > > > do not need for AM62x evm configurations. > > > > > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > > --- > > > > New patch (part of bootstd transition) > > > > > > > > include/configs/am62x_evm.h | 3 --- > > > > 1 file changed, 3 deletions(-) > > > > > > What about include/configs/verdin-am62.h ? > > > > > > It seems that that board, which is am62x based, also has the un-needed > > > include. > > > > > > Since i'm not 100% sure, I have added Marcel (who posted the verdin am62 > > > support) here. > > > > Toradex team, Can you handle that cleanup? I stayed focussed on am62x_evm side > > of things. > > Yes, of course. I believe that this is used on verdin-am62, please double check marcel.
On Thu, Aug 24, 2023 at 06:09:54PM +0200, Francesco Dolcini wrote: > On Thu, Aug 24, 2023 at 01:02:21PM +0000, Marcel Ziswiler wrote: > > On Thu, 2023-08-24 at 07:05 -0500, Nishanth Menon wrote: > > > On 10:13-20230824, Mattijs Korpershoek wrote: > > > > Hi Nishanth, > > > > > > > > On mer., août 23, 2023 at 22:10, Nishanth Menon <nm@ti.com> wrote: > > > > > > > > > Drop unused macro. This was meant for a second region of DDR which we > > > > > do not need for AM62x evm configurations. > > > > > > > > > > Signed-off-by: Nishanth Menon <nm@ti.com> > > > > > --- > > > > > New patch (part of bootstd transition) > > > > > > > > > > include/configs/am62x_evm.h | 3 --- > > > > > 1 file changed, 3 deletions(-) > > > > > > > > What about include/configs/verdin-am62.h ? > > > > > > > > It seems that that board, which is am62x based, also has the un-needed > > > > include. > > > > > > > > Since i'm not 100% sure, I have added Marcel (who posted the verdin am62 > > > > support) here. > > > > > > Toradex team, Can you handle that cleanup? I stayed focussed on am62x_evm side > > > of things. > > > > Yes, of course. > > I believe that this is used on verdin-am62, please double check marcel. No, likely I need to go home and not spread incomplete information here ...
On Thu, 2023-08-24 at 18:15 +0200, Francesco Dolcini wrote: [snip] > > > > > What about include/configs/verdin-am62.h ? > > > > > > > > > > It seems that that board, which is am62x based, also has the un-needed > > > > > include. > > > > > > > > > > Since i'm not 100% sure, I have added Marcel (who posted the verdin am62 > > > > > support) here. > > > > > > > > Toradex team, Can you handle that cleanup? I stayed focussed on am62x_evm side > > > > of things. > > > > > > Yes, of course. > > > > I believe that this is used on verdin-am62, please double check marcel. > > No, likely I need to go home and not spread incomplete information here ... (;-p) We took care of it. https://lore.kernel.org/all/20230828215037.482278-1-marcel@ziswiler.com Thanks! Cheers Marcel
diff --git a/include/configs/am62x_evm.h b/include/configs/am62x_evm.h index 44180dc7687b..379e0c13a395 100644 --- a/include/configs/am62x_evm.h +++ b/include/configs/am62x_evm.h @@ -12,9 +12,6 @@ #include <config_distro_bootcmd.h> #include <env/ti/mmc.h> -/* DDR Configuration */ -#define CFG_SYS_SDRAM_BASE1 0x880000000 - /* Now for the remaining common defines */ #include <configs/ti_armv7_common.h>
Drop unused macro. This was meant for a second region of DDR which we do not need for AM62x evm configurations. Signed-off-by: Nishanth Menon <nm@ti.com> --- New patch (part of bootstd transition) include/configs/am62x_evm.h | 3 --- 1 file changed, 3 deletions(-)