| Message ID | 20230818-clk-fix-v1-1-49ec18f820bf@outlook.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Sean Anderson |
| Headers | show |
| Series | clk: A few bugfixes/enhancements for CCF | expand |
On 8/17/23 13:04, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > It's already implemented in clk-mux.c, export it in the header file. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > include/linux/clk-provider.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h > index b8acacd49e..801404480b 100644 > --- a/include/linux/clk-provider.h > +++ b/include/linux/clk-provider.h > @@ -247,6 +247,12 @@ struct clk *clk_register_mux(struct device *dev, const char *name, > void __iomem *reg, u8 shift, u8 width, > u8 clk_mux_flags); > > +struct clk *clk_register_mux_table(struct device *dev, const char *name, > + const char * const *parent_names, u8 num_parents, > + unsigned long flags, > + void __iomem *reg, u8 shift, u32 mask, > + u8 clk_mux_flags, u32 *table); > + > struct clk *clk_register_fixed_rate(struct device *dev, const char *name, > ulong rate); > > Why do you want to export this? None of your other patches use it. --Sean
On 11/2/2023 1:50 AM, Sean Anderson wrote: > On 8/17/23 13:04, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> It's already implemented in clk-mux.c, export it in the header file. >> >> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >> --- >> include/linux/clk-provider.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h >> index b8acacd49e..801404480b 100644 >> --- a/include/linux/clk-provider.h >> +++ b/include/linux/clk-provider.h >> @@ -247,6 +247,12 @@ struct clk *clk_register_mux(struct device *dev, >> const char *name, >> void __iomem *reg, u8 shift, u8 width, >> u8 clk_mux_flags); >> +struct clk *clk_register_mux_table(struct device *dev, const char >> *name, >> + const char * const *parent_names, u8 num_parents, >> + unsigned long flags, >> + void __iomem *reg, u8 shift, u32 mask, >> + u8 clk_mux_flags, u32 *table); >> + >> struct clk *clk_register_fixed_rate(struct device *dev, const char >> *name, >> ulong rate); >> > > Why do you want to export this? None of your other patches use it. It will be used in HiSilicon clk framework driver which i will send after this series is applied. And this function is exported in Linux kernel CCF. So i think it's fine to export it in U-Boot as well. > > --Sean
On 11/1/23 14:37, Yang Xiwen wrote: > On 11/2/2023 1:50 AM, Sean Anderson wrote: >> On 8/17/23 13:04, Yang Xiwen via B4 Relay wrote: >>> From: Yang Xiwen <forbidden405@outlook.com> >>> >>> It's already implemented in clk-mux.c, export it in the header file. >>> >>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >>> --- >>> include/linux/clk-provider.h | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h >>> index b8acacd49e..801404480b 100644 >>> --- a/include/linux/clk-provider.h >>> +++ b/include/linux/clk-provider.h >>> @@ -247,6 +247,12 @@ struct clk *clk_register_mux(struct device *dev, >>> const char *name, >>> void __iomem *reg, u8 shift, u8 width, >>> u8 clk_mux_flags); >>> +struct clk *clk_register_mux_table(struct device *dev, const char >>> *name, >>> + const char * const *parent_names, u8 num_parents, >>> + unsigned long flags, >>> + void __iomem *reg, u8 shift, u32 mask, >>> + u8 clk_mux_flags, u32 *table); >>> + >>> struct clk *clk_register_fixed_rate(struct device *dev, const char >>> *name, >>> ulong rate); >>> >> >> Why do you want to export this? None of your other patches use it. > It will be used in HiSilicon clk framework driver which i will send > after this series is applied. And this function is exported in Linux > kernel CCF. So i think it's fine to export it in U-Boot as well. Please just send it along with that series then. --Sean
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index b8acacd49e..801404480b 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -247,6 +247,12 @@ struct clk *clk_register_mux(struct device *dev, const char *name, void __iomem *reg, u8 shift, u8 width, u8 clk_mux_flags); +struct clk *clk_register_mux_table(struct device *dev, const char *name, + const char * const *parent_names, u8 num_parents, + unsigned long flags, + void __iomem *reg, u8 shift, u32 mask, + u8 clk_mux_flags, u32 *table); + struct clk *clk_register_fixed_rate(struct device *dev, const char *name, ulong rate);