diff mbox series

[01/28] moveconfig: Drop -C option

Message ID 20230810163212.2368374-2-sjg@chromium.org
State Rejected
Delegated to: Tom Rini
Headers show
Series moveconfig: Drop old code and tidy up | expand

Commit Message

Simon Glass Aug. 10, 2023, 4:31 p.m. UTC 
Drop this option, which is no longer needed now that we have converted
all CONFIG options to Kconfig.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/moveconfig.py | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Tom Rini Aug. 10, 2023, 4:45 p.m. UTC | #1 
On Thu, Aug 10, 2023 at 10:31:33AM -0600, Simon Glass wrote:

> Drop this option, which is no longer needed now that we have converted
> all CONFIG options to Kconfig.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

NAK, I use this every -rc release as the configs do change around as
part of resyncing them, and in turn as options change places slightly
and/or dependencies get fixed.
diff mbox series

Patch

diff --git a/tools/moveconfig.py b/tools/moveconfig.py
index 6cbecc3d5c8..83c53911284 100755
--- a/tools/moveconfig.py
+++ b/tools/moveconfig.py
@@ -1940,8 +1940,6 @@  doc/develop/moveconfig.rst for documentation.'''
                       help='build a CONFIG database')
     parser.add_argument('-c', '--color', action='store_true', default=False,
                       help='display the log in color')
-    parser.add_argument('-C', '--commit', action='store_true', default=False,
-                      help='Create a git commit for the operation')
     parser.add_argument('-d', '--defconfigs', type=str,
                       help='a file containing a list of defconfigs to move, '
                       "one per line (for example 'snow_defconfig') "
@@ -2048,18 +2046,6 @@  doc/develop/moveconfig.rst for documentation.'''
         cleanup_headers(configs, args)
         cleanup_readme(configs, args)
 
-    if args.commit:
-        subprocess.call(['git', 'add', '-u'])
-        if configs:
-            msg = 'Convert %s %sto Kconfig' % (configs[0],
-                    'et al ' if len(configs) > 1 else '')
-            msg += ('\n\nThis converts the following to Kconfig:\n   %s\n' %
-                    '\n   '.join(configs))
-        else:
-            msg = 'configs: Resync with savedefconfig'
-            msg += '\n\nRsync all defconfig files using moveconfig.py'
-        subprocess.call(['git', 'commit', '-s', '-m', msg])
-
     if args.build_db:
         with open(CONFIG_DATABASE, 'w', encoding='utf-8') as fd:
             for defconfig, configs in config_db.items():